linux-kernel - Re: [PATCH] regulator: tps65219: Fix devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCHtYgweLhO4nNhNLtJ-_25guqER7ohDf7TNy8WNFwo898wPw@mail.gmail.com>
Date: Fri, 20 Jun 2025 08:30:41 -0500
From: Robert Nelson <robertcnelson@...il.com>
To: Shree Ramamoorthy <s-ramamoorthy@...com>
Cc: aaro.koskinen@....fi, andreas@...nade.info, khilman@...libre.com, 
	rogerq@...nel.org, tony@...mide.com, lee@...nel.org, d-gole@...com, 
	jkridner@...il.com, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, 
	m-leonard@...com, praneeth@...com, afd@...com
Subject: Re: [PATCH] regulator: tps65219: Fix devm_kmalloc size allocation

On Thu, Jun 19, 2025 at 7:09 PM Shree Ramamoorthy <s-ramamoorthy@...com> wrote:
>
> In probe(), devm_kmalloc uses pmic->common_irq_size to allocate an array of
> 2 bytes, but pmic->common_irq_size is being used like an array of structs.
> The param sent should've been pmic->common_irq_size * sizeof(*irq_data).
> This led to an issue with the kmalloc'd buffer being corrupted and EVM boot
> issues. The common and device-specific structs are now allocated one at a
> time within the loop.
>
> Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
> Reported-by: Dhruva Gole <d-gole@...com>
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@...com>

Thanks Shree!  Starting testing on PB2/BeaglePlay's..


> base-commit: 5c8013ae2e86ec36b07500ba4cacb14ab4d6f728
> prerequisite-patch-id: cd76c901948780de20e932cf620806959e2177b1
> prerequisite-patch-id: e847098a38d07e5ff31e8c80d86d9702d132fdad
> prerequisite-patch-id: e6a01f111e527c6da442f6756f8daa4e79d0fa3c

ps, worked around these 3 missing in v6.16-rc2, which git tree do you
have them staged?

Regards,

-- 
Robert Nelson
https://rcn-ee.com/