linux-kernel - Re: [PATCH 2/2] filemap: Add __filemap_get_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFWR-2WAQ283SZvg@casper.infradead.org>
Date: Fri, 20 Jun 2025 17:53:15 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Shivank Garg <shivankg@....com>, seanjc@...gle.com, david@...hat.com,
	vbabka@...e.cz, akpm@...ux-foundation.org, shuah@...nel.org,
	pbonzini@...hat.com, brauner@...nel.org, viro@...iv.linux.org.uk
Cc: ackerleytng@...gle.com, paul@...l-moore.com, jmorris@...ei.org,
	serge@...lyn.com, pvorel@...e.cz, bfoster@...hat.com,
	tabba@...gle.com, vannapurve@...gle.com, chao.gao@...el.com,
	bharata@....com, nikunj@....com, michael.day@....com,
	yan.y.zhao@...el.com, Neeraj.Upadhyay@....com,
	thomas.lendacky@....com, michael.roth@....com, aik@....com,
	jgg@...dia.com, kalyazin@...zon.com, peterx@...hat.com,
	jack@...e.cz, rppt@...nel.org, hch@...radead.org,
	cgzones@...glemail.com, ira.weiny@...el.com, rientjes@...gle.com,
	roypat@...zon.co.uk, ziy@...dia.com, matthew.brost@...el.com,
	joshua.hahnjy@...il.com, rakie.kim@...com, byungchul@...com,
	gourry@...rry.net, kent.overstreet@...ux.dev,
	ying.huang@...ux.alibaba.com, apopple@...dia.com,
	chao.p.peng@...el.com, amit@...radead.org, ddutile@...hat.com,
	dan.j.williams@...el.com, ashish.kalra@....com, gshan@...hat.com,
	jgowans@...zon.com, pankaj.gupta@....com, papaluri@....com,
	yuzhao@...gle.com, suzuki.poulose@....com, quic_eberman@...cinc.com,
	aneeshkumar.kizhakeveetil@....com, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, kvm@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-coco@...ts.linux.dev
Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote:
> +struct folio *__filemap_get_folio_mpol(struct address_space *mapping,
> +		pgoff_t index, fgf_t fgp_flags, gfp_t gfp,
> +		struct mempolicy *policy)
>  {
>  	struct folio *folio;
>  
> @@ -1982,7 +1984,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index,
>  			err = -ENOMEM;
>  			if (order > min_order)
>  				alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN;
> -			folio = filemap_alloc_folio(alloc_gfp, order, NULL);
> +			folio = filemap_alloc_folio(alloc_gfp, order, policy);
>  			if (!folio)
>  				continue;

This is missing the EXPORT_SYMBOL_GPL() change.  Sorry about that.
I'm sure you can fix it up ;-)  I only tested "make O=.build-all/ -j16
mm/ fs/" (on an allmodconfig) which doesn't get as far as making sure
that modules can still see all the symbols they need.