linux-kernel - Re: [PATCH 2/2] filemap: Add __filemap_get_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250622114322.c6c35800e01e4cc4007a0f89@linux-foundation.org>
Date: Sun, 22 Jun 2025 11:43:22 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: Shivank Garg <shivankg@....com>, seanjc@...gle.com, david@...hat.com,
 vbabka@...e.cz, shuah@...nel.org, pbonzini@...hat.com, brauner@...nel.org,
 viro@...iv.linux.org.uk, ackerleytng@...gle.com, paul@...l-moore.com,
 jmorris@...ei.org, serge@...lyn.com, pvorel@...e.cz, bfoster@...hat.com,
 tabba@...gle.com, vannapurve@...gle.com, chao.gao@...el.com,
 bharata@....com, nikunj@....com, michael.day@....com, yan.y.zhao@...el.com,
 Neeraj.Upadhyay@....com, thomas.lendacky@....com, michael.roth@....com,
 aik@....com, jgg@...dia.com, kalyazin@...zon.com, peterx@...hat.com,
 jack@...e.cz, rppt@...nel.org, hch@...radead.org, cgzones@...glemail.com,
 ira.weiny@...el.com, rientjes@...gle.com, roypat@...zon.co.uk,
 ziy@...dia.com, matthew.brost@...el.com, joshua.hahnjy@...il.com,
 rakie.kim@...com, byungchul@...com, gourry@...rry.net,
 kent.overstreet@...ux.dev, ying.huang@...ux.alibaba.com,
 apopple@...dia.com, chao.p.peng@...el.com, amit@...radead.org,
 ddutile@...hat.com, dan.j.williams@...el.com, ashish.kalra@....com,
 gshan@...hat.com, jgowans@...zon.com, pankaj.gupta@....com,
 papaluri@....com, yuzhao@...gle.com, suzuki.poulose@....com,
 quic_eberman@...cinc.com, aneeshkumar.kizhakeveetil@....com,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
 kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-coco@...ts.linux.dev
Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

On Fri, 20 Jun 2025 17:53:15 +0100 Matthew Wilcox <willy@...radead.org> wrote:

> On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote:
> > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping,
> > +		pgoff_t index, fgf_t fgp_flags, gfp_t gfp,
> > +		struct mempolicy *policy)
> >  {
> >  	struct folio *folio;
> >  
> > @@ -1982,7 +1984,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index,
> >  			err = -ENOMEM;
> >  			if (order > min_order)
> >  				alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN;
> > -			folio = filemap_alloc_folio(alloc_gfp, order, NULL);
> > +			folio = filemap_alloc_folio(alloc_gfp, order, policy);
> >  			if (!folio)
> >  				continue;
> 
> This is missing the EXPORT_SYMBOL_GPL() change

I added this:

--- a/mm/filemap.c~filemap-add-__filemap_get_folio_mpol-fix
+++ a/mm/filemap.c
@@ -2032,7 +2032,7 @@ no_page:
 		folio_clear_dropbehind(folio);
 	return folio;
 }
-EXPORT_SYMBOL(__filemap_get_folio);
+EXPORT_SYMBOL(__filemap_get_folio_mpol);
 
 static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max,
 		xa_mark_t mark)
_