linux-kernel - Re: [PATCH v5 3/4] dt-bindings: clock: cdce6214: add binding for pin configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fcb5ca6-7881-44c2-a658-752fa7cd5f38@kernel.org>
Date: Fri, 20 Jun 2025 08:06:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 kernel@...gutronix.de, Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH v5 3/4] dt-bindings: clock: cdce6214: add binding for pin
 configuration

On 19/06/2025 13:28, Sascha Hauer wrote:
> On Thu, Jun 19, 2025 at 09:42:06AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Jun 18, 2025 at 11:21:14AM GMT, Sascha Hauer wrote:
>>> Add pin configuration binding for the TI CDCE6214. The CDCE6214 has
>>> an internal EEPROM to to fully configure the chip, but this EEPROM
>>> might be empty, so add support for configuring the chip through
>>> the device tree.
>>>
>>> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
>>> ---
>>>  .../devicetree/bindings/clock/ti,cdce6214.yaml     | 95 ++++++++++++++++++++++
>>>  1 file changed, 95 insertions(+)
>>
>>
>> This should be part of previous patch. Bindings should be complete, not
>> added in partial sets.
> 
> See cover letter why I did this. If everybody is fine with the pin
> configuration binding then I can merge this back together, but I doubt
> it and in that case I'd rather get the driver upstream without the pin
> configuration at first.

We expect bindings to be complete, not added in chunks and drivers do
not matter here that much. You can still discuss the drivers, afterwards.

Best regards,
Krzysztof