linux-kernel - Re: [PATCH v2 4/6] arm64: dts: axiado: Add initial support for AX3000 SoC and eval board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9012cc61-b499-4213-9753-54cf4d24c822@kernel.org>
Date: Fri, 20 Jun 2025 08:08:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshit Shah <hshah@...ado.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Arnd Bergmann <arnd@...db.de>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "soc@...ts.linux.dev" <soc@...ts.linux.dev>
Subject: Re: [PATCH v2 4/6] arm64: dts: axiado: Add initial support for AX3000
 SoC and eval board

On 20/06/2025 00:41, Harshit Shah wrote:
>>> +
>>> +             spi_clk: spi_clk {
>>> +                     compatible = "fixed-clock";
>>> +                     #clock-cells = <0>;
>>> +                     clock-frequency = <25000000>;
>>> +             };
>>> +
>>> +             apb_pclk: apb_pclk {
>> No underscores in node names, but all these look incorrect - don't you
>> have clock controller?
> Noted, we will remove the "_" from the nodes. We do have clock 
> controller however that is being accessed by other CPU before Linux will 
> come-up.

What does it mean? Is the clock controller not available at all for
Linux or any other OS?

> 
> So, the purpose of this clock nodes is to calculate the frequencies for 
> other peripherals. (We will update the nodes with clock-<freq>)

You do not calculate any frequencies here... You created nodes for fixed
clocks but I question here whether these are fixed clocks.

Where are these clocks located exactly?


Best regards,
Krzysztof