linux-kernel - Re: [PATCH v4] ARM: dts: aspeed: yosemite4: add gpio name for uart mux sel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <623c8da5fdf3bb69b6b63733beb4a63b38cf6c7d.camel@codeconstruct.com.au>
Date: Fri, 20 Jun 2025 16:57:24 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: MarshallZhan-wiwynn <marshall_zhan@...ynn.com>, patrick@...cx.xyz
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 devicetree@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ARM: dts: aspeed: yosemite4: add gpio name for uart
 mux sel

Hi Marshall,

On Wed, 2025-06-18 at 15:08 +0800, MarshallZhan-wiwynn wrote:
> Add gpio line name to support multiplexed console
> 
> Signed-off-by: Marshall Zhan <marshall_zhan@...ynn.com>

Thanks for fixing the email situation. However, I notice your git
username is set to `MashallZhan-wiwynn`, which is different how you've
filled out the Signed-off-by tag. I'd prefer you make them consistent.
You can do this with:

   git config --global user.name "Marshall Zhan"
   
Some people choose to include their employer like you have. Typically
this is done like:

   git config --global user.name "Marshall Zhan (Wiwynn)"
   
The patch is fine otherwise.

Thanks,

Andrew