linux-kernel - Re: [External] : Re: [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6uix26h.wl-tiwai@suse.de>
Date: Fri, 20 Jun 2025 10:11:34 +0200
From: Takashi Iwai <tiwai@...e.de>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	perex@...ex.cz,
	tiwai@...e.com,
	phasta@...nel.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [External] : Re: [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH_DI2L SDIN

On Thu, 19 Jun 2025 21:26:53 +0200,
ALOK TIWARI wrote:
> 
> 
> 
> On 6/19/2025 9:08 PM, Andy Shevchenko wrote:
> > On Wed, Jun 18, 2025 at 12:19:21PM -0700, Alok Tiwari wrote:
> >> Correct the index to use codec[i] to match the loop iteration, not codec[1].
> >> 
> >> Is this a mistake or intentional?
> > 
> > You marked it as a BUG in the Subject, can you elaborate more, please?
> > 
> 
> I should have mark this as a query.
> Why is the value 1 hardcoded here in the codec?
> 
> tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;
> 
> https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/pci/intel8x0.c#n2252

I believe this is a long-standing bug, but practically seen, it never
hits on real devices, because there have been little devices with
multiple AC97 codecs on Intel ICH, and they have at most only two
codecs, AFAIK.

That said, I'd happily take the fix patch when you submit a properly
formatted one.  It'll likely change the behavior of existing devices,
but it's always good to fix something.


thanks,

Takashi