linux-kernel - Re: [External] : Re: [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <668f9127-25e2-418e-beb6-79ff96706914@oracle.com>
Date: Fri, 20 Jun 2025 00:56:53 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: perex@...ex.cz, tiwai@...e.com, phasta@...nel.org,
        linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [External] : Re: [BUG] ALSA: intel8x: Why incorrect codec index
 used setting ICH_DI2L SDIN



On 6/19/2025 9:08 PM, Andy Shevchenko wrote:
> On Wed, Jun 18, 2025 at 12:19:21PM -0700, Alok Tiwari wrote:
>> Correct the index to use codec[i] to match the loop iteration, not codec[1].
>>
>> Is this a mistake or intentional?
> 
> You marked it as a BUG in the Subject, can you elaborate more, please?
> 

I should have mark this as a query.
Why is the value 1 hardcoded here in the codec?

tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;

https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/pci/intel8x0.c#n2252


Thanks,
Alok