linux-kernel - RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool NFC using Default Queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB9254669DB8DEF4132693B0D9D87CA@IA3PR11MB9254.namprd11.prod.outlook.com>
Date: Fri, 20 Jun 2025 08:23:05 +0000
From: "Song, Yoong Siang" <yoong.siang.song@...el.com>
To: Kurt Kanzenbach <kurt@...utronix.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper
 Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	"Gomes, Vinicius" <vinicius.gomes@...el.com>, Jonathan Corbet
	<corbet@....net>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	Shinas Rasheed <srasheed@...vell.com>, "Tian, Kevin" <kevin.tian@...el.com>,
	Brett Creeley <brett.creeley@....com>, "Blanco Alcaine, Hector"
	<hector.blanco.alcaine@...el.com>, "Hay, Joshua A" <joshua.a.hay@...el.com>,
	Sasha Neftin <sasha.neftin@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "Marcin Szycik"
	<marcin.szycik@...ux.intel.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool
 NFC using Default Queue

On Friday, June 20, 2025 3:46 PM, Kurt Kanzenbach <kurt@...utronix.de> wrote:
>On Thu Jun 19 2025, Song Yoong Siang wrote:
>> Introduce support for a lowest priority wildcard (catch-all) rule in
>> ethtool's Network Flow Classification (NFC) for the igc driver. The
>> wildcard rule directs all unmatched network traffic, including traffic not
>> captured by Receive Side Scaling (RSS), to a specified queue. This
>> functionality utilizes the Default Queue feature available in I225/I226
>> hardware.
>>
>> The implementation has been validated on Intel ADL-S systems with two
>> back-to-back connected I226 network interfaces.
>>
>> Testing Procedure:
>> 1. On the Device Under Test (DUT), verify the initial statistic:
>>    $ ethtool -S enp1s0 | grep rx_q.*packets
>>         rx_queue_0_packets: 0
>>         rx_queue_1_packets: 0
>>         rx_queue_2_packets: 0
>>         rx_queue_3_packets: 0
>>
>> 2. From the Link Partner, send 10 ARP packets:
>>    $ arping -c 10 -I enp170s0 169.254.1.2
>>
>> 3. On the DUT, verify the packet reception on Queue 0:
>>    $ ethtool -S enp1s0 | grep rx_q.*packets
>>         rx_queue_0_packets: 10
>>         rx_queue_1_packets: 0
>>         rx_queue_2_packets: 0
>>         rx_queue_3_packets: 0
>>
>> 4. On the DUT, add a wildcard rule to route all packets to Queue 3:
>>    $ sudo ethtool -N enp1s0 flow-type ether queue 3
>>
>> 5. From the Link Partner, send another 10 ARP packets:
>>    $ arping -c 10 -I enp170s0 169.254.1.2
>>
>> 6. Now, packets are routed to Queue 3 by the wildcard (Default Queue) rule:
>>    $ ethtool -S enp1s0 | grep rx_q.*packets
>>         rx_queue_0_packets: 10
>>         rx_queue_1_packets: 0
>>         rx_queue_2_packets: 0
>>         rx_queue_3_packets: 10
>>
>> 7. On the DUT, add a EtherType rule to route ARP packet to Queue 1:
>>    $ sudo ethtool -N enp1s0 flow-type ether proto 0x0806 queue 1
>>
>> 8. From the Link Partner, send another 10 ARP packets:
>>    $ arping -c 10 -I enp170s0 169.254.1.2
>>
>> 9. Now, packets are routed to Queue 1 by the EtherType rule because it is
>>    higher priority than the wildcard (Default Queue) rule:
>>    $ ethtool -S enp1s0 | grep rx_q.*packets
>>         rx_queue_0_packets: 10
>>         rx_queue_1_packets: 10
>>         rx_queue_2_packets: 0
>>         rx_queue_3_packets: 10
>>
>> 10. On the DUT, delete all the NFC rules:
>>     $ sudo ethtool -N enp1s0 delete 63
>>     $ sudo ethtool -N enp1s0 delete 64
>>
>> 11. From the Link Partner, send another 10 ARP packets:
>>     $ arping -c 10 -I enp170s0 169.254.1.2
>>
>> 12. Now, packets are routed to Queue 0 because the value of Default Queue
>>     is reset back to 0:
>>     $ ethtool -S enp1s0 | grep rx_q.*packets
>>          rx_queue_0_packets: 20
>>          rx_queue_1_packets: 10
>>          rx_queue_2_packets: 0
>>          rx_queue_3_packets: 10
>>
>> Co-developed-by: Blanco Alcaine Hector <hector.blanco.alcaine@...el.com>
>> Signed-off-by: Blanco Alcaine Hector <hector.blanco.alcaine@...el.com>
>> Signed-off-by: Song Yoong Siang <yoong.siang.song@...el.com>
>
>Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Hi Kurt Kanzenbach,

Thank you for reviewing the patch.
Brett Creeley points out a nit to have separate patch to
move following macros from igc.h to igc_defines.h.

#define IGC_MRQC_ENABLE_RSS_MQ         0x00000002
#define IGC_MRQC_RSS_FIELD_IPV4_UDP    0x00400000
#define IGC_MRQC_RSS_FIELD_IPV6_UDP    0x00800000

I plan to split this patch into two, then submit v3 patchset
with your reviewed-by tag on both patches.
Is this sound good to you?

Thanks & Regards
Siang