linux-kernel - RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool NFC using Default Queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB925440EB3352EC0E164DBB06D87CA@IA3PR11MB9254.namprd11.prod.outlook.com>
Date: Fri, 20 Jun 2025 08:30:47 +0000
From: "Song, Yoong Siang" <yoong.siang.song@...el.com>
To: Brett Creeley <bcreeley@....com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper
 Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
	"Gomes, Vinicius" <vinicius.gomes@...el.com>, Jonathan Corbet
	<corbet@....net>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	Shinas Rasheed <srasheed@...vell.com>, "Tian, Kevin" <kevin.tian@...el.com>,
	Brett Creeley <brett.creeley@....com>, "Blanco Alcaine, Hector"
	<hector.blanco.alcaine@...el.com>, "Hay, Joshua A" <joshua.a.hay@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, Kurt Kanzenbach <kurt@...utronix.de>, "Marcin
 Szycik" <marcin.szycik@...ux.intel.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool
 NFC using Default Queue

On Thursday, June 19, 2025 11:49 PM, Brett Creeley <bcreeley@....com> wrote:
>On 6/19/2025 8:37 AM, Song Yoong Siang wrote:
>> diff --git a/drivers/net/ethernet/intel/igc/igc.h
>b/drivers/net/ethernet/intel/igc/igc.h
>> index 1525ae25fd3e..c580ecc954be 100644
>> --- a/drivers/net/ethernet/intel/igc/igc.h
>> +++ b/drivers/net/ethernet/intel/igc/igc.h
>> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>>   #define IGC_FLAG_RSS_FIELD_IPV4_UDP    BIT(6)
>>   #define IGC_FLAG_RSS_FIELD_IPV6_UDP    BIT(7)
>>
>> -#define IGC_MRQC_ENABLE_RSS_MQ         0x00000002
>> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP    0x00400000
>> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP    0x00800000
>> -
>
>Small nit, but moving these fields seems like a separate patch since
>moving them isn't part of the wildcard rule changes.
>
>Thanks,
>
>Brett

Hi Brett,

Thanks for reviewing the patch.
No problem, I can split the patch into two and submit v3.

Thanks & Regards
Siang