| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHVXubi46zgpKkKmGZvu7mNdfBLAsjgpLauLEfysUP05FMtyCQ@mail.gmail.com>
Date: Fri, 20 Jun 2025 10:32:36 +0200
From: Alexandre Ghiti <alexghiti@...osinc.com>
To: kernel test robot <lkp@...el.com>
Cc: Andy Chiu <andy.chiu@...ive.com>, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, Palmer Dabbelt <palmer@...belt.com>,
Björn Töpel <bjorn@...osinc.com>
Subject: Re: include/linux/ftrace.h:190:9: error: call to undeclared function
'arch_ftrace_get_regs'; ISO C99 and later do not support implicit function declarations
On Thu, Jun 19, 2025 at 1:21 PM kernel test robot <lkp@...el.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: fb4d33ab452ea254e2c319bac5703d1b56d895bf
> commit: d0262e907e2991ae09ca476281fc8cae3ec57850 riscv: ftrace: support PREEMPT
> date: 2 weeks ago
> config: riscv-randconfig-r071-20250619 (https://download.01.org/0day-ci/archive/20250619/202506191949.o3SMu8Zn-lkp@intel.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 875b36a8742437b95f623bab1e0332562c7b4b3f)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506191949.o3SMu8Zn-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506191949.o3SMu8Zn-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/riscv/kernel/asm-offsets.c:10:
> >> include/linux/ftrace.h:190:9: error: call to undeclared function 'arch_ftrace_get_regs'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 190 | return arch_ftrace_get_regs(fregs);
> | ^
> include/linux/ftrace.h:190:9: note: did you mean 'ftrace_get_regs'?
> include/linux/ftrace.h:185:40: note: 'ftrace_get_regs' declared here
> 185 | static __always_inline struct pt_regs *ftrace_get_regs(struct ftrace_regs *fregs)
> | ^
> 186 | {
> 187 | if (!fregs)
> 188 | return NULL;
> 189 |
> 190 | return arch_ftrace_get_regs(fregs);
> | ~~~~~~~~~~~~~~~~~~~~
> | ftrace_get_regs
> >> include/linux/ftrace.h:190:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct pt_regs *' [-Wint-conversion]
> 190 | return arch_ftrace_get_regs(fregs);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
This is what I came up with because after fixing this ^, we get other
similar failures. My level of confidence on this one is pretty low
though, so if someone can confirm, that'd be nice:
diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
index 22ebea3c2b26c..28319c50d0315 100644
--- a/arch/riscv/include/asm/ftrace.h
+++ b/arch/riscv/include/asm/ftrace.h
@@ -49,7 +49,7 @@ struct dyn_arch_ftrace {
};
#endif
-#ifdef CONFIG_DYNAMIC_FTRACE
+#ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS
/*
* A general call in RISC-V is a pair of insts:
* 1) auipc: setting high-20 pc-related bits to ra register
@@ -117,7 +117,6 @@ struct dyn_ftrace;
int ftrace_init_nop(struct module *mod, struct dyn_ftrace *rec);
#define ftrace_init_nop ftrace_init_nop
-#ifdef CONFIG_DYNAMIC_FTRACE_WITH_ARGS
#define arch_ftrace_get_regs(regs) NULL
#define HAVE_ARCH_FTRACE_REGS
struct ftrace_ops;
@@ -233,8 +232,6 @@ static inline void
arch_ftrace_set_direct_caller(struct ftrace_regs *fregs, unsi
}
#endif /* CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS */
-#endif /* CONFIG_DYNAMIC_FTRACE_WITH_ARGS */
-
#endif /* __ASSEMBLY__ */
#endif /* CONFIG_DYNAMIC_FTRACE */
diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offsets.c
index 6e8c0d6feae9e..f29b33358a328 100644
--- a/arch/riscv/kernel/asm-offsets.c
+++ b/arch/riscv/kernel/asm-offsets.c
@@ -505,7 +505,7 @@ void asm_offsets(void)
#endif /* CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS */
#endif
-#ifdef CONFIG_DYNAMIC_FTRACE_WITH_ARGS
+#ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS
DEFINE(FREGS_SIZE_ON_STACK, ALIGN(sizeof(struct
__arch_ftrace_regs), STACK_ALIGN));
DEFINE(FREGS_EPC, offsetof(struct __arch_ftrace_regs, epc));
DEFINE(FREGS_RA, offsetof(struct __arch_ftrace_regs, ra));
Thanks,
Alex
> 2 errors generated.
> make[3]: *** [scripts/Makefile.build:98: arch/riscv/kernel/asm-offsets.s] Error 1
> make[3]: Target 'prepare' not remade because of errors.
> make[2]: *** [Makefile:1282: prepare0] Error 2
> make[2]: Target 'prepare' not remade because of errors.
> make[1]: *** [Makefile:248: __sub-make] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:248: __sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
>
>
> vim +/arch_ftrace_get_regs +190 include/linux/ftrace.h
>
> 762abbc0d09f7a Masami Hiramatsu (Google 2024-12-26 184)
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 185) static __always_inline struct pt_regs *ftrace_get_regs(struct ftrace_regs *fregs)
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 186) {
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 187) if (!fregs)
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 188) return NULL;
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 189)
> 02a474ca266a47 Steven Rostedt (VMware 2020-10-27 @190) return arch_ftrace_get_regs(fregs);
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 191) }
> d19ad0775dcd64 Steven Rostedt (VMware 2020-10-28 192)
>
> :::::: The code at line 190 was first introduced by commit
> :::::: 02a474ca266a47ea8f4d5a11f4ffa120f83730ad ftrace/x86: Allow for arguments to be passed in to ftrace_regs by default
>
> :::::: TO: Steven Rostedt (VMware) <rostedt@...dmis.org>
> :::::: CC: Steven Rostedt (VMware) <rostedt@...dmis.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists