linux-kernel - [PATCH] platform/x86/amd_isp4: prevent built-in configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250620115448.202425-1-arnd@kernel.org>
Date: Fri, 20 Jun 2025 13:54:45 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Hans de Goede <hansg@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Pratap Nirujogi <pratap.nirujogi@....com>,
	Benjamin Chan <benjamin.chan@....com>,
	Mario Limonciello <mario.limonciello@....com>
Cc: Arnd Bergmann <arnd@...db.de>,
	kernel test robot <lkp@...el.com>,
	Armin Wolf <W_Armin@....de>,
	Basavaraj Natikar <Basavaraj.Natikar@....com>,
	Suma Hegde <suma.hegde@....com>,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

From: Arnd Bergmann <arnd@...db.de>

Checking the module owner of the device only works when modules are
enabled, and the device is created from a module:

drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'

Building the driver as a loadable module avoids the build failure,
though this should probably be fixed in a different way that still
works if the device was created from built-in code.

Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/x86/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
index 63e4bd985699..9e150500e37e 100644
--- a/drivers/platform/x86/amd/Kconfig
+++ b/drivers/platform/x86/amd/Kconfig
@@ -36,6 +36,7 @@ config AMD_WBRF
 config AMD_ISP_PLATFORM
 	tristate "AMD ISP4 platform driver"
 	depends on I2C && X86_64 && ACPI
+	depends on m
 	help
 	  Platform driver for AMD platforms containing image signal processor
 	  gen 4. Provides camera sensor module board information to allow
-- 
2.39.5