linux-kernel - Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e4edb94-e2fc-4e32-bc27-3b0bc5ccd74f@amd.com>
Date: Fri, 20 Jun 2025 16:02:54 -0400
From: "Nirujogi, Pratap" <pnirujog@....com>
To: Arnd Bergmann <arnd@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Pratap Nirujogi <pratap.nirujogi@....com>,
 Benjamin Chan <benjamin.chan@....com>,
 Mario Limonciello <mario.limonciello@....com>
Cc: Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
 Armin Wolf <W_Armin@....de>, Basavaraj Natikar <Basavaraj.Natikar@....com>,
 Suma Hegde <suma.hegde@....com>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 "Chan, Benjamin (Koon Pan)" <benjamin.chan@....com>, Bin Du
 <bin.du@....com>, "Rosikopulos, Gjorgji" <gjorgji.rosikopulos@....com>,
 "Li, King" <king.li@....com>, Phil.Jawich@....com
Subject: Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

Hi Arnd,

Thanks for the patch.

On 6/20/2025 7:54 AM, Arnd Bergmann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> Checking the module owner of the device only works when modules are
> enabled, and the device is created from a module:
> 
> drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'
> 
> Building the driver as a loadable module avoids the build failure,
> though this should probably be fixed in a different way that still
> works if the device was created from built-in code.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/platform/x86/amd/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index 63e4bd985699..9e150500e37e 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -36,6 +36,7 @@ config AMD_WBRF
>   config AMD_ISP_PLATFORM
>          tristate "AMD ISP4 platform driver"
>          depends on I2C && X86_64 && ACPI
> +       depends on m
This issue is reported earlier and the fix has been submitted to replace 
adap->owner->name with adap->name to remove the dependency on 
CONFIG_MODULES. But until the fix is accepted and is available on either 
i2c or pdx86 tree, I think its good to have this fix to avoid the build 
errors.

https://lore.kernel.org/all/20250609155601.1477055-4-pratap.nirujogi@amd.com/

Reviewed-by: Pratap Nirujogi <pratap.nirujogi@....com>

Thanks,
Pratap



>          help
>            Platform driver for AMD platforms containing image signal processor
>            gen 4. Provides camera sensor module board information to allow
> --
> 2.39.5
>