linux-kernel - Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49a6a302-8660-5072-27b9-abc61253f608@linux.intel.com>
Date: Thu, 26 Jun 2025 18:18:07 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Arnd Bergmann <arnd@...nel.org>
cc: Hans de Goede <hansg@...nel.org>, 
    Pratap Nirujogi <pratap.nirujogi@....com>, 
    Benjamin Chan <benjamin.chan@....com>, 
    Mario Limonciello <mario.limonciello@....com>, 
    Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>, 
    Armin Wolf <W_Armin@....de>, Basavaraj Natikar <Basavaraj.Natikar@....com>, 
    Suma Hegde <suma.hegde@....com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration

On Fri, 20 Jun 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> Checking the module owner of the device only works when modules are
> enabled, and the device is created from a module:
> 
> drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'
> 
> Building the driver as a loadable module avoids the build failure,
> though this should probably be fixed in a different way that still
> works if the device was created from built-in code.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/platform/x86/amd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index 63e4bd985699..9e150500e37e 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -36,6 +36,7 @@ config AMD_WBRF
>  config AMD_ISP_PLATFORM
>  	tristate "AMD ISP4 platform driver"
>  	depends on I2C && X86_64 && ACPI
> +	depends on m
>  	help
>  	  Platform driver for AMD platforms containing image signal processor
>  	  gen 4. Provides camera sensor module board information to allow
> 

The fix series should finally be on its way to Linus through i2c tree. 
I'm sorry for the unexpected delay in getting the real fix applied.

-- 
 i.