linux-kernel - Re: [PATCH v1 03/55] media: i2c: ar0521: Use the v4l2 helper for obtaining the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <VI1P193MB068579285B70F3B7EECD136F837FA@VI1P193MB0685.EURP193.PROD.OUTLOOK.COM>
Date: Sat, 21 Jun 2025 10:21:20 +0000
From: Krzysztof Hałasa | Łukasiewicz – PIAP
	<krzysztof.halasa@...p.lukasiewicz.gov.pl>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
CC: "hverkuil@...all.nl" <hverkuil@...all.nl>, "jacopo.mondi@...asonboard.com"
	<jacopo.mondi@...asonboard.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: Re: [PATCH v1 03/55] media: i2c: ar0521: Use the v4l2 helper for
 obtaining the clock

Hi Mehdi,

I guess it's the same as all other patches in the series.

Sorry if the message formatting is weird - I'm a bit offline now.

> devm_clk_get() fails on ACPI-based platforms, where firmware does not
> provide a direct reference to the clock producer.

> Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get()
> that works on both DT- and ACPI-based platforms to retrieve a reference to
> the clock producer from firmware.

> Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>

Acked-By: Krzysztof Hałasa <khalasa@...p.pl>

--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -1077,7 +1077,7 @@ static int ar0521_probe(struct i2c_client *client)
        }

        /* Get master clock (extclk) */
-       sensor->extclk = devm_clk_get(dev, "extclk");
+       sensor->extclk = devm_v4l2_sensor_clk_get(dev, "extclk");
        if (IS_ERR(sensor->extclk)) {
                dev_err(dev, "failed to get extclk\n");
                return PTR_ERR(sensor->extclk);