linux-kernel - Re: [PATCH v1 19/55] media: i2c: imx415: Use the v4l2 helper for obtaining the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0eb440d8-fdc3-4ceb-8856-cda43afde4d1@collabora.com>
Date: Sat, 21 Jun 2025 16:23:23 +0200
From: Michael Riesch <michael.riesch@...labora.com>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>,
 laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com
Cc: akinobu.mita@...il.com, stanislaw.gruszka@...ux.intel.com,
 hdegoede@...hat.com, arnd@...db.de, alain.volmat@...s.st.com,
 andrzej.hajda@...el.com, benjamin.mugnier@...s.st.com,
 dave.stevenson@...pberrypi.com, hansg@...nel.org, hverkuil@...all.nl,
 jacopo.mondi@...asonboard.com, jonas@...boo.se,
 kieran.bingham@...asonboard.com, khalasa@...p.pl,
 prabhakar.csengg@...il.com, mani@...nel.org, m.felsch@...gutronix.de,
 martink@...teo.de, mattwmajewski@...il.com, matthias.fend@...end.at,
 mchehab@...nel.org, naush@...pberrypi.com, nicholas@...hemail.net,
 nicolas.dufresne@...labora.com, paul.elder@...asonboard.com,
 dan.scally@...asonboard.com, pavel@...nel.org, petrcvekcz@...il.com,
 rashanmu@...il.com, ribalda@...omium.org, rmfrfs@...il.com,
 zhengsq@...k-chips.com, slongerbeam@...il.com, sylvain.petinot@...s.st.com,
 s.nawrocki@...sung.com, tomi.valkeinen@...asonboard.com,
 umang.jain@...asonboard.com, zhi.mao@...iatek.com,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v1 19/55] media: i2c: imx415: Use the v4l2 helper for
 obtaining the clock

Hi Mehdi,

Thanks for your patch!

On 6/19/25 19:59, Mehdi Djait wrote:
> devm_clk_get() fails on ACPI-based platforms, where firmware does not
> provide a direct reference to the clock producer.
> 
> Replace devm_clk_get() with the new v4l2 helper
> devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
> platforms to retrieve a reference to the clock producer from firmware.
> 
> Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 9f37779bd611..f7897660f44f 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
>  				     "failed to get reset GPIO\n");
>  
> -	sensor->clk = devm_clk_get(sensor->dev, "inck");
> +	sensor->clk = devm_v4l2_sensor_clk_get(sensor->dev, "inck");

Matthias Fend discovered a while ago that the driver is not in agreement
with the DT binding, which does not require a certain clock name.
However, the corresponding patch [0] has not landed in v6.16-rc1 AFAIK.

Can we translate the line above directly to
    sensor->clk = devm_v4l2_sensor_clk_get(sensor->dev, NULL);
?

Best regards,
Michael

>  	if (IS_ERR(sensor->clk))
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
>  				     "failed to get clock\n");


[0] https://lore.kernel.org/all/20250514-imx415-v1-1-bb29fa622bb1@emfend.at/