linux-kernel - Re: [PATCH V3 net-next 5/8] net: hns3: set the freed pointers to NULL when lifetime is not end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250621083310.52c8e7ae@kernel.org>
Date: Sat, 21 Jun 2025 08:33:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <horms@...nel.org>, <shenjian15@...wei.com>,
 <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
 <chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
 <shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 net-next 5/8] net: hns3: set the freed pointers to
 NULL when lifetime is not end

On Thu, 19 Jun 2025 22:40:54 +0800 Jijie Shao wrote:
> ChangeLog:
> v2 -> v3:
>   - Remove unnecessary pointer set to NULL operation, suggested by Simon Horman.
>   v2: https://lore.kernel.org/all/20250617010255.1183069-1-shaojijie@huawei.com/

You removed a single case, but I'm pretty sure Simon meant _all_
cases setting local variables to NULL in this patch are pointless.
-- 
pw-bot: cr