linux-kernel - Re: [PATCH net-next 3/3] net: hibmcge: configure FIFO thresholds according to the MAC controller documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250621083543.67459b3b@kernel.org>
Date: Sat, 21 Jun 2025 08:35:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <horms@...nel.org>, <shenjian15@...wei.com>,
 <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
 <chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
 <shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: hibmcge: configure FIFO thresholds
 according to the MAC controller documentation

On Thu, 19 Jun 2025 22:44:23 +0800 Jijie Shao wrote:
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_FULL_M, full);
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);
> +	}
> +
> +	if (dir & HBG_DIR_RX) {
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_FULL_M, full);
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);

nit checkpatch says:

WARNING: line length of 81 exceeds 80 columns
#62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
+		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);

ERROR: space prohibited before that ',' (ctx:WxW)
#62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
+		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);
 		                                                      	^

WARNING: line length of 81 exceeds 80 columns
#67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
+		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);

ERROR: space prohibited before that ',' (ctx:WxW)
#67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
+		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);
 		                                                      	^

total: 2 errors, 2 warnings, 0 checks, 79 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.
-- 
pw-bot: cr