linux-kernel - Re: [GIT PULL] smb3 client fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5msQwv4LuaF=kmmy_n=z5paCyat2vTZowOB46WeJxpwhiQ@mail.gmail.com>
Date: Sat, 21 Jun 2025 11:00:02 -0500
From: Steve French <smfrench@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, CIFS <linux-cifs@...r.kernel.org>
Subject: Re: [GIT PULL] smb3 client fixes

I can remove that and resend, handling special files properly can be
important (and there is a much more important patch being reviewed for
fixing some symlink corner cases) but SMB1 is much lower priority.

On Sat, Jun 21, 2025 at 10:55 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Fri, 20 Jun 2025 at 15:57, Steve French <smfrench@...il.com> wrote:
> >
> > - Fix reparse points (special file handling) for SMB1
>
> I'm not seeing this being a fix at all. This seems to be entirely new
> functionality, with not even a whiff of "this fixes Xyz".
>
> I pulled and then unpulled again. Because WTF?
>
> If it's a real fix for a real problem, it needs to be explained as such.
>
> And if it is what it looks like and the explanation says it is, then
> it damn well shouldn't be hidden in a "fixes" pull and tried to be
> sneaked in with the pull request dressing it up as anything else.
>
>                  Linus



-- 
Thanks,

Steve