linux-kernel - Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250621181339.0331ab8b@jic23-huawei>
Date: Sat, 21 Jun 2025 18:13:39 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, "linux-iio@...r.kernel.org"
 <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX
 integer types

On Tue, 17 Jun 2025 21:33:46 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Tue, Jun 17, 2025 at 5:43 PM Jean-Baptiste Maneyrol
> <Jean-Baptiste.Maneyrol@....com> wrote:
> > >From: Andy Shevchenko <andy.shevchenko@...il.com>
> > >Sent: Monday, June 16, 2025 16:33
> > >On Mon, Jun 16, 2025 at 5:16 PM Jean-Baptiste Maneyrol
> > ><Jean-Baptiste.Maneyrol@....com> wrote:
> > >  
> > >> thanks a lot for having done all the work.  
> > >
> > >Please, avoid top-posting!
> > >  
> > >> Do you think it is possible to add a fixes tag so it can be backported to ease automatic backport of further patches?
> > >> Otherwise for sure all further fixes will have to be backported manually.  
> > >
> > >The idea behind the series that it may depend on some kind of
> > >cleanups. In such a case (according to Greg KH) no need to have Fixes
> > >tag on a cleanup, because it's confusing. On the contrary the
> > >infrastructure for stable kernels will catch this up. You need to
> > >follow the Documentation on how to submit for stable (basically the
> > >main hint is to use stable@ in the Cc line _inside_ the commit
> > >message, as a tag).
> > >  
> > >> The driver code is full of intXX_t and uintXX_t types which is
> > >> not the pattern we use in the IIO subsystem. Switch the driver
> > >> to use kernel internal types for that. No functional changes.  
> 
> > >> As noted before the pattern is used in less than 10% files in IIO,
> > >> So it's safe to assume that IIO prefers uXX/sXX types over C99 ones.  
> > >  
> >
> > it is good for me if we can add Cc to stable.
> > I don't know if I need to add the Cc tag here or when a fixed patch will
> > require the rework. In doubt, here it is.
> >
> > Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
> > Cc: stable@...r.kernel.org  
> 
> It makes no sense here. This is a standalone change. It's not part of
> any "fixes" series. You need to attach this patch to your series as
> patch 1 and mark Cc stable all of the patches.
> 

I think this is hypothetical at the moment as the only series outstanding
is the WOM one which isn't a fix.  So I don't think this patch will
ever end up carrying a stable tag.  However, first time we get a fix
that needs it, if Greg etc don't sort it out anyway (they often do!)
then a simple mail to stable@...r.kernel.org to tell them to pick this
and the fix will resolve it.

For now I'll queue this patch up and ask for a rebase on the WOM
series on top of it.

It crossed with David's series doing {} to replace explicit memsets
so needed a tiny bit of hand tweaking.
Pushed out as testing for 0-day to look at.

Thanks,

Jonathan