linux-kernel - [PATCH] i3c: master: Initialize ret in i3c_i2c_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250622-i3c-master-ret-uninitialized-v1-1-aabb5625c932@analog.com>
Date: Sun, 22 Jun 2025 12:11:07 +0200
From: Jorge Marques <jorge.marques@...log.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Frank Li
	<Frank.Li@....com>
CC: <linux-i3c@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        "Jorge
 Marques" <jorge.marques@...log.com>
Subject: [PATCH] i3c: master: Initialize ret in i3c_i2c_notifier_call()

Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
action, resolving uninitialized warning.

Signed-off-by: Jorge Marques <jorge.marques@...log.com>
---
If a invalid action was passed to i3c_i2c_notifier_call(), uninitialized
would be returned. Add a default option in the switch case to set it as
-EINVAL; I didn't set at the variable definition for readability
purpose. The warning was caught by smatch.
---
 drivers/i3c/master.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index fd81871609d95bc082bd401681e7e132ea74f8a7..68b8ea9174b984a6c89b389c4b3a9669239def70 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2467,6 +2467,8 @@ static int i3c_i2c_notifier_call(struct notifier_block *nb, unsigned long action
 	case BUS_NOTIFY_DEL_DEVICE:
 		ret = i3c_master_i2c_detach(adap, client);
 		break;
+	default:
+		ret = -EINVAL;
 	}
 	i3c_bus_maintenance_unlock(&master->bus);
 

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250622-i3c-master-ret-uninitialized-16265d8a8719

Best regards,
-- 
Jorge Marques <jorge.marques@...log.com>