linux-kernel - Re: [PULL REQUEST] i2c-for-6.16-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjCznJeOUSHcR5BszEUVv5BW6heO6jMX38MHXNaL3kbmQ@mail.gmail.com>
Date: Sun, 22 Jun 2025 11:00:48 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Wolfram Sang <wsa@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <brgl@...ev.pl>, Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PULL REQUEST] i2c-for-6.16-rc3

On Sun, 22 Jun 2025 at 06:20, Wolfram Sang <wsa@...nel.org> wrote:
>
> - subsystem: convert drivers to use recent callbacks of struct i2c_algorithm
>   A typical after-rc1 cleanup, which I couldn't send in time for rc2

Honestly, this is just *annoying*.

It's made extra annoying by the fact that you also did some random
whitespace changes while at it, and almost half the lines modified are
just completely irrelevant indentation changes.

Looking at the stats, your pull is:

 45 files changed, 125 insertions(+), 103 deletions(-)

but ignoring the whitespace changes it drops to

 45 files changed, 84 insertions(+), 62 deletions(-)

all of which just makes it really really hard to see that it's just a
trivial conversion.

I've pulled this, but I was really close to just unpulling it because
it was such a messy thing and badly done.

If you do conversions after the merge window, make them DAMN OBVIOUS.
Make them minimal, make them automated, and DO NOT DO OTHER RANDOM
CRAP AROUND THEM.

          Linus