linux-kernel - [PATCH] clk: microchip: mpfs: Fix incorrect MSSPLL ID in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250622180352.4151679-1-alok.a.tiwari@oracle.com>
Date: Sun, 22 Jun 2025 11:03:49 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: conor.dooley@...rochip.com, daire.mcnamara@...rochip.com,
        mturquette@...libre.com, sboyd@...nel.org,
        linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org
Cc: alok.a.tiwari@...cle.com, linux-kernel@...r.kernel.org
Subject: [PATCH] clk: microchip: mpfs: Fix incorrect MSSPLL ID in error message

The error message in mpfs_clk_register_mssplls() incorrectly
printed a constant CLK_MSSPLL_INTERNAL instead of the actual
PLL ID that failed to register.

Update it to msspll_hw->id for accurate diagnostics

Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
 drivers/clk/microchip/clk-mpfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
index c22632a7439c5..d12b7120f16ff 100644
--- a/drivers/clk/microchip/clk-mpfs.c
+++ b/drivers/clk/microchip/clk-mpfs.c
@@ -160,7 +160,7 @@ static int mpfs_clk_register_mssplls(struct device *dev, struct mpfs_msspll_hw_c
 		ret = devm_clk_hw_register(dev, &msspll_hw->hw);
 		if (ret)
 			return dev_err_probe(dev, ret, "failed to register msspll id: %d\n",
-					     CLK_MSSPLL_INTERNAL);
+					     msspll_hw->id);
 
 		data->hw_data.hws[msspll_hw->id] = &msspll_hw->hw;
 	}
-- 
2.46.0