linux-kernel - Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with sysfs_emit in bo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeTbMORBBd0N65w3m4nZ8s6GUKaK8u40P_+Ki8yPPyCxA@mail.gmail.com>
Date: Sun, 22 Jun 2025 23:52:01 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
Cc: andy@...nel.org, hansg@...nel.org, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with
 sysfs_emit in bo_show

On Sun, Jun 22, 2025 at 11:42 PM Abdelrahman Fekry
<abdelrahmanfekry375@...il.com> wrote:
> On Sun, Jun 22, 2025 at 23:39 Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>> On Sun, Jun 22, 2025 at 11:37 PM Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>> > On Sun, Jun 22, 2025 at 9:54 AM Abdelrahman Fekry
>> > <abdelrahmanfekry375@...il.com> wrote:

...

>> > > +       /* Changing to sysfs_emit changes the behaviour if failed*/
>> >
>> > This comment, besides missing the space, is useless here. You need to
>> > use the comment block for the proposed change.
>>
>> Also the text of the comment is a noise. You need to explain better
>> what's going on here.
>
> Noted , so the comment is enough if well written or i should do something else?

First of all, it's a bare minimum, which means that you should go
deeper into the code to understand the issue to begin with. Second,
the comment should be put in the proper place. In the code it's
useless as it describes something that is absent in the code for odd
reasons. Talk to your mentors and ask them for help because explaining
more is basically doing your job for you. And IIUC the purpose of
mentoring is to make sure you learn something and have acknowledged
this in practice.

-- 
With Best Regards,
Andy Shevchenko