linux-kernel - Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with sysfs_emit in bo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGn2d8OrqEqZnkENHau6b75WqpN9V_pG1kJChMEQvwQOa40cmA@mail.gmail.com>
Date: Mon, 23 Jun 2025 00:06:08 +0300
From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: andy@...nel.org, hansg@...nel.org, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with
 sysfs_emit in bo_show

On Sun, Jun 22, 2025 at 11:52 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Sun, Jun 22, 2025 at 11:42 PM Abdelrahman Fekry
> <abdelrahmanfekry375@...il.com> wrote:
> > On Sun, Jun 22, 2025 at 23:39 Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> >> On Sun, Jun 22, 2025 at 11:37 PM Andy Shevchenko
> >> <andy.shevchenko@...il.com> wrote:
> >> > On Sun, Jun 22, 2025 at 9:54 AM Abdelrahman Fekry
> >> > <abdelrahmanfekry375@...il.com> wrote:


> First of all, it's a bare minimum, which means that you should go
> deeper into the code to understand the issue to begin with. Second,
> the comment should be put in the proper place. In the code it's
> useless as it describes something that is absent in the code for odd
> reasons. Talk to your mentors and ask them for help because explaining
> more is basically doing your job for you. And IIUC the purpose of
> mentoring is to make sure you learn something and have acknowledged
> this in practice.
>
Thanks , i will come back with v3 with more explanation and details.
> --
> With Best Regards,
> Andy Shevchenko