linux-kernel - Re: [PATCH v6 22/24] thermal/drivers/imx: convert to use devm_request*_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aFlwqaNvHtPk7wbR@lizhi-Precision-Tower-5810>
Date: Mon, 23 Jun 2025 11:20:09 -0400
From: Frank Li <Frank.li@....com>
To: Pan Chuang <panchuang@...o.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-pm@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Yangtao Li <frank.li@...o.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v6 22/24] thermal/drivers/imx: convert to use
 devm_request*_irq_probe()

On Mon, Jun 23, 2025 at 08:42:57PM +0800, Pan Chuang wrote:
> From: Yangtao Li <frank.li@...o.com>
>
> The new devm_request_*irq_probe API prints an error message by default
> when the request fails, and consumers can provide custom error messages.
>
> Converting drivers to use this API has the following benefits:
>
>   1.More than 2,000 lines of code can be saved by removing redundant error
>   messages in drivers.

This one should be total save, not for this patch. Each patch's commit
message should be independent.

You just need said, use new API to simple code because commit xxx add new
helper function devm_request_threaded_irq_probe().

Frank
>
>   2.Upper-layer functions can directly return error codes without missing
>   debugging information.
>
>   3.Having proper and consistent information about why the device cannot
>   be used is useful.
>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Cc: AngeloGioacchino Del Regno  <angelogioacchino.delregno@...labora.com>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> Signed-off-by: Pan Chuang <panchuang@...o.com>
> ---
>  drivers/thermal/imx_thermal.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index bab52e6b3b15..151976d0820e 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -729,13 +729,12 @@ static int imx_thermal_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto thermal_zone_unregister;
>
> -	ret = devm_request_threaded_irq(dev, data->irq,
> -			imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
> -			0, "imx_thermal", data);
> -	if (ret < 0) {
> -		dev_err(dev, "failed to request alarm irq: %d\n", ret);
> +	ret = devm_request_threaded_irq_probe(dev, data->irq,
> +					      imx_thermal_alarm_irq,
> +					      imx_thermal_alarm_irq_thread,
> +					      0, "imx_thermal", data, "alarm");
> +	if (ret < 0)
>  		goto thermal_zone_unregister;
> -	}
>
>  	pm_runtime_put(data->dev);
>
> --
> 2.39.0
>