linux-kernel - Re: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a55ywkwd.fsf@bootlin.com>
Date: Mon, 23 Jun 2025 17:13:54 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Pan Chuang <panchuang@...o.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,  Daniel Lezcano
 <daniel.lezcano@...aro.org>,  Zhang Rui <rui.zhang@...el.com>,  Lukasz
 Luba <lukasz.luba@....com>,  Markus Mayer <mmayer@...adcom.com>,  Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
  Florian Fainelli <florian.fainelli@...adcom.com>,  Shawn Guo
 <shawnguo@...nel.org>,  Sascha Hauer <s.hauer@...gutronix.de>,
  Pengutronix Kernel Team <kernel@...gutronix.de>,  Fabio Estevam
 <festevam@...il.com>,  zhanghongchen <zhanghongchen@...ngson.cn>,  Yinbo
 Zhu <zhuyinbo@...ngson.cn>,  Amit Kucheria <amitk@...nel.org>,  Thara
 Gopinath <thara.gopinath@...il.com>,  Niklas Söderlund
 <niklas.soderlund@...natech.se>,  Geert Uytterhoeven
 <geert+renesas@...der.be>,  Magnus Damm <magnus.damm@...il.com>,  Heiko
 Stuebner <heiko@...ech.de>,  Bartlomiej Zolnierkiewicz
 <bzolnier@...il.com>,  Krzysztof Kozlowski <krzk@...nel.org>,  Alim Akhtar
 <alim.akhtar@...sung.com>,  Maxime Coquelin <mcoquelin.stm32@...il.com>,
  Alexandre Torgue <alexandre.torgue@...s.st.com>,  Vasily Khoruzhick
 <anarsoul@...il.com>,  Yangtao Li <tiny.windzz@...il.com>,  Chen-Yu Tsai
 <wens@...e.org>,  Jernej Skrabec <jernej.skrabec@...il.com>,  Samuel
 Holland <samuel@...lland.org>,  Thierry Reding <thierry.reding@...il.com>,
  Jonathan Hunter <jonathanh@...dia.com>,  Kunihiko Hayashi
 <hayashi.kunihiko@...ionext.com>,  Masami Hiramatsu <mhiramat@...nel.org>,
  Thomas Gleixner <tglx@...utronix.de>,  Matthias Brugger
 <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,  Srinivas Pandruvada
 <srinivas.pandruvada@...ux.intel.com>,  Greg KH
 <gregkh@...uxfoundation.org>,  Peter Zijlstra <peterz@...radead.org>,
  Nícolas F. R. A. Prado <nfraprado@...labora.com>,  Conor
 Dooley
 <conor.dooley@...rochip.com>,  Julien Panis <jpanis@...libre.com>,  Arnd
 Bergmann <arnd@...db.de>,  Uwe Kleine-König
 <u.kleine-koenig@...libre.com>,  Colin Ian King <colin.i.king@...il.com>,
  Raphael Gallais-Pou <rgallaispou@...il.com>,  Patrice Chotard
 <patrice.chotard@...s.st.com>,  Jonathan Cameron
 <Jonathan.Cameron@...wei.com>,  "Jiri Slaby (SUSE)"
 <jirislaby@...nel.org>,  Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>,  Andrew Morton <akpm@...ux-foundation.org>,
  Costa Shulyupin <costa.shul@...hat.com>,  Yury Norov
 <yury.norov@...il.com>,  Cheng-Yang Chou <yphbchou0911@...il.com>,  Caleb
 Sander Mateos <csander@...estorage.com>,  linux-pm@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  imx@...ts.linux.dev,  linux-arm-msm@...r.kernel.org,
  linux-renesas-soc@...r.kernel.org,  linux-rockchip@...ts.infradead.org,
  linux-samsung-soc@...r.kernel.org,
  linux-stm32@...md-mailman.stormreply.com,  linux-sunxi@...ts.linux.dev,
  linux-tegra@...r.kernel.org,  linux-mediatek@...ts.infradead.org,
  Yangtao Li <frank.li@...o.com>,  Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v6 01/24] genirq/devres: Add
 devm_request_threaded_irq_probe() and devm_request_irq_probe()

Hi Pan,

On 23/06/2025 at 20:30:34 +08, Pan Chuang <panchuang@...o.com> wrote:

> From: Yangtao Li <frank.li@...o.com>
>
> There are more than 700 calls to devm_request_threaded_irq method and
> more than 1000 calls to devm_request_irq method. Most drivers only
> request one interrupt resource, and these error messages are basically
> the same. If error messages are printed everywhere, more than 2000 lines
> of code can be saved by removing the msg in the driver.

[...]

> So add devm_request_threaded_irq_probe() and devm_request_irq_probe(),
> which ensure that all error handling branches print error information.
> In this way, when this function fails, the upper-layer functions can
> directly return an error code without missing debugging information.
> Otherwise, the error message will be printed redundantly or missing.

While I understand the goal and adhere to it, may I challenge the use of
a yet another intermediate function that 99% of the users will anyway
use? Wouldn't it be more straightforward to just add the error message
in the existing functions directly? If we really want an alternative, it
may be created and called in the few places where a dev_err_probe()
might not be relevant.

Thanks,
Miquèl