linux-kernel - Re: [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bcc6786-772f-4298-928f-34f3c6dc64d6@infradead.org>
Date: Mon, 23 Jun 2025 13:44:58 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, linux-nvme@...ts.infradead.org,
 kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 kch@...dia.com, nilay@...ux.ibm.com, corbet@....net
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] nvme: Fix incorrect variable in io cqes error message



On 6/22/25 11:40 PM, Alok Tiwari wrote:
> Corrected the error log to print ctrl->io_cqes instead of
> incorrectly using ctrl->io_sqes for the io cqes size check.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/nvme/target/pci-epf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c
> index a4295a5b8d280..44288d8f5aa11 100644
> --- a/drivers/nvme/target/pci-epf.c
> +++ b/drivers/nvme/target/pci-epf.c
> @@ -1860,7 +1860,7 @@ static int nvmet_pci_epf_enable_ctrl(struct nvmet_pci_epf_ctrl *ctrl)
>  	ctrl->io_cqes = 1UL << nvmet_cc_iocqes(ctrl->cc);
>  	if (ctrl->io_cqes < sizeof(struct nvme_completion)) {
>  		dev_err(ctrl->dev, "Unsupported I/O CQES %zu (need %zu)\n",
> -			ctrl->io_sqes, sizeof(struct nvme_completion));
> +			ctrl->io_cqes, sizeof(struct nvme_completion));
>  		goto err;
>  	}
>  

-- 
~Randy