linux-kernel - Re: [PATCH 3/5] nvmet: Remove redundant assignment of error code in nvmet_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50e80a33-30cc-4231-87ad-c0fa392acf45@infradead.org>
Date: Mon, 23 Jun 2025 13:45:31 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, linux-nvme@...ts.infradead.org,
 kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 kch@...dia.com, nilay@...ux.ibm.com, corbet@....net
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] nvmet: Remove redundant assignment of error code in
 nvmet_ns_enable()



On 6/22/25 11:40 PM, Alok Tiwari wrote:
> removing the unnecessary ret = -EMFILE; assignment since it is
> immediately overwritten by the result of nvmet_bdev_ns_enable()
> The initial value(-EMFILE) is redundant because it has no effect
> on the code logic or outcome.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/nvme/target/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index 175c5b6d4dd58..884286f90688a 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -581,8 +581,6 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
>  	if (ns->enabled)
>  		goto out_unlock;
>  
> -	ret = -EMFILE;
> -
>  	ret = nvmet_bdev_ns_enable(ns);
>  	if (ret == -ENOTBLK)
>  		ret = nvmet_file_ns_enable(ns);

-- 
~Randy