linux-kernel - Re: [PATCH 4/5] nvme: Fix typo in status code constant for self-test in progress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff61ff8e-d20c-444e-988f-6d97a197e070@infradead.org>
Date: Mon, 23 Jun 2025 13:46:17 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, linux-nvme@...ts.infradead.org,
 kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 kch@...dia.com, nilay@...ux.ibm.com, corbet@....net
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] nvme: Fix typo in status code constant for self-test
 in progress



On 6/22/25 11:40 PM, Alok Tiwari wrote:
> Corrected a typo error in the NVMe status code constant from
> NVME_SC_SELT_TEST_IN_PROGRESS to NVME_SC_SELF_TEST_IN_PROGRESS to
> accurately reflect its meaning.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/nvme/host/constants.c | 4 ++--
>  include/linux/nvme.h          | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
> index 1a0058be58210..dc90df9e13a21 100644
> --- a/drivers/nvme/host/constants.c
> +++ b/drivers/nvme/host/constants.c
> @@ -133,7 +133,7 @@ static const char * const nvme_statuses[] = {
>  	[NVME_SC_NS_NOT_ATTACHED] = "Namespace Not Attached",
>  	[NVME_SC_THIN_PROV_NOT_SUPP] = "Thin Provisioning Not Supported",
>  	[NVME_SC_CTRL_LIST_INVALID] = "Controller List Invalid",
> -	[NVME_SC_SELT_TEST_IN_PROGRESS] = "Device Self-test In Progress",
> +	[NVME_SC_SELF_TEST_IN_PROGRESS] = "Device Self-test In Progress",
>  	[NVME_SC_BP_WRITE_PROHIBITED] = "Boot Partition Write Prohibited",
>  	[NVME_SC_CTRL_ID_INVALID] = "Invalid Controller Identifier",
>  	[NVME_SC_SEC_CTRL_STATE_INVALID] = "Invalid Secondary Controller State",
> @@ -145,7 +145,7 @@ static const char * const nvme_statuses[] = {
>  	[NVME_SC_BAD_ATTRIBUTES] = "Conflicting Attributes",
>  	[NVME_SC_INVALID_PI] = "Invalid Protection Information",
>  	[NVME_SC_READ_ONLY] = "Attempted Write to Read Only Range",
> -	[NVME_SC_CMD_SIZE_LIM_EXCEEDED	] = "Command Size Limits Exceeded",
> +	[NVME_SC_CMD_SIZE_LIM_EXCEEDED] = "Command Size Limits Exceeded",
>  	[NVME_SC_ZONE_BOUNDARY_ERROR] = "Zoned Boundary Error",
>  	[NVME_SC_ZONE_FULL] = "Zone Is Full",
>  	[NVME_SC_ZONE_READ_ONLY] = "Zone Is Read Only",
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index b65a1b9f2116c..655d194f8e722 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -2155,7 +2155,7 @@ enum {
>  	NVME_SC_NS_NOT_ATTACHED		= 0x11a,
>  	NVME_SC_THIN_PROV_NOT_SUPP	= 0x11b,
>  	NVME_SC_CTRL_LIST_INVALID	= 0x11c,
> -	NVME_SC_SELT_TEST_IN_PROGRESS	= 0x11d,
> +	NVME_SC_SELF_TEST_IN_PROGRESS	= 0x11d,
>  	NVME_SC_BP_WRITE_PROHIBITED	= 0x11e,
>  	NVME_SC_CTRL_ID_INVALID		= 0x11f,
>  	NVME_SC_SEC_CTRL_STATE_INVALID	= 0x120,

-- 
~Randy