linux-kernel - Re: [PATCH] selftests/nolibc: avoid GCC 15 -Wunterminated-string-initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250623213712.GA30367@1wt.eu>
Date: Mon, 23 Jun 2025 23:37:12 +0200
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Shuah Khan <shuah@...nel.org>, Rodrigo Campos <rodrigo@...g.com.ar>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: avoid GCC 15
 -Wunterminated-string-initialization

On Mon, Jun 23, 2025 at 11:34:32PM +0200, Thomas Weißschuh wrote:
> On GCC 15 the following warnings is emitted:
> 
> nolibc-test.c: In function 'run_stdlib':
> nolibc-test.c:1416:32: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (11 chars into 10 available) [-Wunterminated-string-initialization]
>  1416 |                 char buf[10] = "test123456";
>       |                                ^~~~~~~~~~~~
> 
> Increase the size of buf to avoid the warning.
> 
> It would also be possible to use __attribute__((nonstring)) but that
> would require some ifdeffery to work with older compilers.

I agree with you, that's not an important enough fight to spend time
on :-)

> Fixes: 1063649cf531 ("selftests/nolibc: Add tests for strlcat() and strlcpy()")
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Acked-by: Willy Tarreau <w@....eu>

willy