linux-kernel - Re: [PATCH] selftests/nolibc: avoid GCC 15 -Wunterminated-string-initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86bc2557-b9cc-4767-9379-e60786b3f825@sdfg.com.ar>
Date: Tue, 24 Jun 2025 13:08:51 +0200
From: Rodrigo Campos <rodrigo@...g.com.ar>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Willy Tarreau <w@....eu>, Shuah Khan <shuah@...nel.org>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: avoid GCC 15
 -Wunterminated-string-initialization

On 6/23/25 11:34 PM, Thomas Weißschuh wrote:
> On GCC 15 the following warnings is emitted:
> 
> nolibc-test.c: In function ‘run_stdlib’:
> nolibc-test.c:1416:32: warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (11 chars into 10 available) [-Wunterminated-string-initialization]
>   1416 |                 char buf[10] = "test123456";
>        |                                ^~~~~~~~~~~~
> 
> Increase the size of buf to avoid the warning.
> 
> It would also be possible to use __attribute__((nonstring)) but that
> would require some ifdeffery to work with older compilers.
> 
> Fixes: 1063649cf531 ("selftests/nolibc: Add tests for strlcat() and strlcpy()")
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>   tools/testing/selftests/nolibc/nolibc-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index dbe13000fb1ac153e9a89f627492daeb584a05d4..52640d8ae402b9e34174ae798e74882ca750ec2b 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -1413,7 +1413,7 @@ int run_stdlib(int min, int max)
>   		 * Add some more chars after the \0, to test functions that overwrite the buffer set
>   		 * the \0 at the exact right position.
>   		 */
> -		char buf[10] = "test123456";
> +		char buf[11] = "test123456";
>   		buf[4] = '\0';

Reviewed-by: Rodrigo Campos <rodrigo@...g.com.ar>

Sorry for the typo :)



Best,
Rodrigo