lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025062349-proximity-trapeze-24c6@gregkh>
Date: Mon, 23 Jun 2025 08:28:12 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, Sasha Levin <sashal@...nel.org>,
	Xuerui Wang <kernel@...0n.name>, stable@...r.kernel.org,
	ziyao@...root.org, linux-kernel@...r.kernel.org,
	loongarch@...ts.linux.dev
Subject: Re: [PATCH for 6.1/6.6] platform/loongarch: laptop: Fix build error
 due to backport

On Sun, Jun 22, 2025 at 09:11:44PM +0800, Huacai Chen wrote:
> On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
> > > In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error
> > > occurs due to recently backport:
> > >
> > >   CC      drivers/platform/loongarch/loongson-laptop.o
> > > drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register':
> > > drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function)
> > >   428 |         props.power = BACKLIGHT_POWER_ON;
> > >       |                       ^~~~~~~~~~~~~~~~~~
> > >
> > > Use FB_BLANK_UNBLANK instead which has the same meaning.
> > >
> > > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > > ---
> > >  drivers/platform/loongarch/loongson-laptop.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > What commit id is this fixing?
> 
> commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.

Great, can you resend this with a proper Fixes: tag so I don't have to
manually add it myself?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ