linux-kernel - Re: [PATCH] ARM: export __memset/__memcpy/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <133e7a14-9c61-46e6-9ac4-e1c17c0c28b1@pengutronix.de>
Date: Mon, 23 Jun 2025 08:27:29 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Arnd Bergmann <arnd@...nel.org>, Russell King <linux@...linux.org.uk>
Cc: Arnd Bergmann <arnd@...db.de>, Abbott Liu <liuwenliang@...wei.com>,
 Ard Biesheuvel <ardb@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Florian Fainelli <f.fainelli@...il.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: export __memset/__memcpy/__memmove

On 20.06.25 13:12, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When KASAN is locally disabled for one file, the string functions
> get redirected to internal helpers, but those are not actually exported,
> so this only works in built-in code but fails for loadable modules:
> 
> ERROR: modpost: "__memset" [crypto/ecc.ko] undefined!
> ERROR: modpost: "__memcpy" [crypto/ecc.ko] undefined!
> 
> Add the missig exports.
> 
> Fixes: d6d51a96c7d6 ("ARM: 9014/2: Replace string mem* functions for KASan")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

> ---
>  arch/arm/kernel/armksyms.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c
> index 82e96ac83684..1ff50106afa4 100644
> --- a/arch/arm/kernel/armksyms.c
> +++ b/arch/arm/kernel/armksyms.c
> @@ -83,10 +83,13 @@ EXPORT_SYMBOL(__raw_writesl);
>  EXPORT_SYMBOL(strchr);
>  EXPORT_SYMBOL(strrchr);
>  EXPORT_SYMBOL(memset);
> +EXPORT_SYMBOL(__memset);
>  EXPORT_SYMBOL(__memset32);
>  EXPORT_SYMBOL(__memset64);
>  EXPORT_SYMBOL(memcpy);
> +EXPORT_SYMBOL(__memcpy);
>  EXPORT_SYMBOL(memmove);
> +EXPORT_SYMBOL(__memmove);
>  EXPORT_SYMBOL(memchr);
>  
>  EXPORT_SYMBOL(mmioset);


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |