linux-kernel - Re: [PATCH 23/33] serial: 8250: extract serial8250_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <054c6d81-aaea-43a2-939e-b845d54c0926@kernel.org>
Date: Mon, 23 Jun 2025 09:20:46 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-serial <linux-serial@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 23/33] serial: 8250: extract serial8250_set_efr()

On 12. 06. 25, 20:54, Andy Shevchenko wrote:
> On Thu, Jun 12, 2025 at 12:01:29PM +0200, Jiri Slaby wrote:
>> On 11. 06. 25, 14:58, Ilpo Järvinen wrote:
>>> On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:
> 
> ...
> 
>>>> +	if (port->flags & UPF_EXAR_EFR)
>>>
>>> I wonder if it is possible to trigger this at all? Only 8250_exar.c sets
>>> this flag and does not contain UART_CAP_EFR at all (nor uses
>>> UPF_BOOT_AUTOCONF)??
> 
> The file indeed does not contain it, BUT it sets it implicitly (via port type).
> So, this is not a dead code. Please, do not remove it.

Ah, both PORT_XR17D15X and PORT_XR17V35X set UART_CAP_EFR in uart_config[].

thanks,
-- 
js
suse labs