linux-kernel - Re: [PATCH 01/33] tty: introduce and use tty_port_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0a07ca3-447a-4e3d-be0b-49892c945179@kernel.org>
Date: Mon, 23 Jun 2025 09:30:34 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-serial <linux-serial@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Karsten Keil <isdn@...ux-pingi.de>,
 David Lin <dtwlin@...il.com>, Johan Hovold <johan@...nel.org>,
 Alex Elder <elder@...nel.org>, Oliver Neukum <oneukum@...e.com>,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Netdev <netdev@...r.kernel.org>, greybus-dev@...ts.linaro.org,
 linux-staging@...ts.linux.dev, linux-usb@...r.kernel.org,
 linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH 01/33] tty: introduce and use tty_port_tty_vhangup()
 helper

On 11. 06. 25, 13:13, Ilpo Järvinen wrote:
> On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:
> 
>> This code (tty_get -> vhangup -> tty_put) is repeated on few places.
>> Introduce a helper similar to tty_port_tty_hangup() (asynchronous) to
>> handle even vhangup (synchronous).
>>
>> And use it on those places.
>>
>> In fact, reuse the tty_port_tty_hangup()'s code and call tty_vhangup()
>> depending on a new bool parameter.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
>> Cc: Karsten Keil <isdn@...ux-pingi.de>
>> Cc: David Lin <dtwlin@...il.com>
>> Cc: Johan Hovold <johan@...nel.org>
>> Cc: Alex Elder <elder@...nel.org>
>> Cc: Oliver Neukum <oneukum@...e.com>
>> Cc: Marcel Holtmann <marcel@...tmann.org>
>> Cc: Johan Hedberg <johan.hedberg@...il.com>
>> Cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>
> 
> Nice cleanup. I'm not sure if it's important enough to be mentioned in
> Documentation/driver-api/tty/tty_port.rst .

At minimum I broke tty_port_tty_hangup()'s kernel-doc:
/**
  * tty_port_tty_hangup - helper to hang up a tty
  * @port: tty port
  * @check_clocal: hang only ttys with %CLOCAL unset?
  */
  void __tty_port_tty_hangup(struct tty_port *port, bool check_clocal, 
bool async)


doc says tty_port_tty_hangup(), code says __tty_port_tty_hangup(). Fix 
coming, incl. vhangup addition.

thanks,
-- 
js
suse labs