linux-kernel - Re: [PATCH 4/5] serial: 8250: document doubled "type == PORT_8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd0-cORgEozDcoogYfO=XscFwvbXhseGfdYNqmE3HHWEQ@mail.gmail.com>
Date: Mon, 23 Jun 2025 11:19:30 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: gregkh@...uxfoundation.org, linux-serial@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Subject: Re: [PATCH 4/5] serial: 8250: document doubled "type ==
 PORT_8250_CIR" check

On Mon, Jun 23, 2025 at 10:46 AM Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
>
> The check for "port.type == PORT_8250_CIR" is present twice in
> serial8250_register_8250_port(). The latter was already tried to be
> dropped by 1104321a7b3b ("serial: Delete dead code for CIR serial
> ports") and then reverted by 9527b82ae3af ("Revert "serial: Delete dead
> code for CIR serial ports"").
>
> Document this weirdness with a reason.

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko