linux-kernel - Re: [PATCH 1/1] check the ioremap return value first (supplementary CC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bf6df3b-affe-4f10-8b05-29f3393d19e0@intel.com>
Date: Mon, 23 Jun 2025 10:45:34 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: chuguangqing <chuguangqing@...pur.com>
CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, Tony Nguyen <anthony.l.nguyen@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>
Subject: Re: [PATCH 1/1] check the ioremap return value first (supplementary
 CC)

On 6/19/25 14:48, chuguangqing wrote:
>   tks to pabeni.
>   cc the relevant ML in the email.
> 

Thank you for reaching out with the patch, it is an attempt to
fix something observable?

I have found the original topic via web search [1]. It looks that the
proposed patch does not change anything - adapter->io_addr was null
also before the assignment, so it does not hurt as-is. And the check
afterwards is equally effective for me to prevent subsequent
dereference.

[1] https://lkml.org/lkml/2025/6/19/343