linux-kernel - Re: [PATCH v1 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250623093156.GBaFkfDAN3bgiyV_IL@fat_crate.local>
Date: Mon, 23 Jun 2025 11:31:56 +0200
From: Borislav Petkov <bp@...en8.de>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Daniel Díaz <daniel.diaz@...aro.org>
Subject: Re: [PATCH v1 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in
 i386_defconfig

On Mon, Jun 23, 2025 at 12:21:03PM +0300, Andy Shevchenko wrote:
> Ah, this is just a cherry-pick (with fixing conflicts, updated Fixes
> and removed the last paragraph) of 5y.o. 76366050eb1b ("x86/defconfigs:
> Explicitly unset CONFIG_64BIT in i386_defconfig"),

What?

A 5yo patch cherrypicked from somewhere has as a Fixes tag a patch from 10
days ago?!?!

> it should be standalone patch. I borrowed the commit message.  So, whatever
> you prefer: I can send it again as the original one, one of x86 maintainers
> can do themselves the cherry-picking / conflict resolution, or I can resend
> it as mine.

You should do a proper patch as it is done and not do a mish-mash of old and
new things, clarify with Daniel who's going to be the author and you should
write a commit message which explains the situation properly, not borrow one.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette