linux-kernel - Re: [PATCH] Bluetooth btusb.c: Add pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ea897245e112fc5a5fbba3d3f34e6f7f51be8fa.camel@hadess.net>
Date: Mon, 23 Jun 2025 11:42:07 +0200
From: Bastien Nocera <hadess@...ess.net>
To: "Sumedh W. Jambekar" <linuxsumedh@...il.com>, marcel@...tmann.org, 
	luiz.dentz@...il.com, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth btusb.c: Add pr_info() for logging.

On Sun, 2025-06-22 at 22:27 +0530, Sumedh W. Jambekar wrote:
> In this commit, the pr_info() call is added in the
> probe function for logging purposes. This is done
> as part of the assignment in the LFD103 course.

Do not submit junk contributions to upstream as part of your course
work. This is a burden on upstream, and you failed to even run it
through checkpatch.pl which would have shown that you used the wrong
spacing.

This is a good way to get blocked upstream, don't send another patch
unless it is something that can be merged upstream.

> 
> Signed-off-by: Sumedh W. Jambekar <linuxsumedh@...il.com>
> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 9ab661d2d1e6..5ecb9a61a33b 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3858,6 +3858,7 @@ static int btusb_probe(struct usb_interface
> *intf,
>  	unsigned ifnum_base;
>  	int i, err, priv_size;
>  
> +    pr_info("SWJ changed the btusb driver in the Linux Kernel\n");
>  	BT_DBG("intf %p id %p", intf, id);
>  
>  	if ((id->driver_info & BTUSB_IFNUM_2) &&