linux-kernel - Re: [PATCH] soc: mediatek: mtk-mutex: Fix confusing usage of MUTEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75d0fe76-2fa3-4ffc-920e-a6a49f428036@collabora.com>
Date: Mon, 23 Jun 2025 11:35:41 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Jason-JH Lin <jason-jh.lin@...iatek.com>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
 Nancy Lin <nancy.lin@...iatek.com>, Singo Chang <singo.chang@...iatek.com>,
 Paul-PL Chen <paul-pl.chen@...iatek.com>,
 Yongqiang Niu <yongqiang.niu@...iatek.com>,
 Zhenxing Qin <zhenxing.qin@...iatek.com>,
 Xiandong Wang <xiandong.wang@...iatek.com>,
 Sirius Wang <sirius.wang@...iatek.com>,
 Xavier Chang <xavier.chang@...iatek.com>,
 Jarried Lin <jarried.lin@...iatek.com>, Fei Shao <fshao@...omium.org>,
 Chen-yu Tsai <wenst@...omium.org>, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH] soc: mediatek: mtk-mutex: Fix confusing usage of
 MUTEX_MOD2

Il 20/06/25 04:40, Jason-JH Lin ha scritto:
> The usage of MUTEX_MOD1 and MUTEX_MOD2 for calculating mod settings
> over 32 has been confusing. To improve consistency and clarity, these
> defines need to fit into the same MUTEX_MOD define as possible.
> 
> However, MUTEX_MOD1 cannot be directly used for all SoCs because,
> for example, the mod1 register (0x34) of MT2712 is not adjacent to
> its mod0 register (0x2c). To address this, a `mutex_mod1_reg` field
> is introduced in the mutex driver data structure. This allows all
> SoCs to use a unified MUTEX_MOD to determine their register offsets.
> 
> With this change, the separate usage of MUTEX_MOD1 and MUTEX_MOD2 is
> eliminated, simplifying the logic for obtaining offsets and mod IDs.

Yeah, okay, that makes sense, but...

> 
> Fixes: e1e4f7fea375 ("soc / drm: mediatek: Move mtk mutex driver to soc folder")

...this is an improvement, it's not a fix, so please drop the Fixes tag.

> Signed-off-by: Jason-JH Lin <jason-jh.lin@...iatek.com>

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>