linux-kernel - Re: [PATCH] soc: mediatek: mtk-mutex: Fix confusing usage of MUTEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1221bfaf8640a27c85940c249ea186c7f82277c2.camel@mediatek.com>
Date: Tue, 24 Jun 2025 09:49:16 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	Zhenxing Qin (秦振兴) <Zhenxing.Qin@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>,
	Yongqiang Niu (牛永强)
	<yongqiang.niu@...iatek.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>,
	Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "fshao@...omium.org"
	<fshao@...omium.org>, Singo Chang (張興國)
	<Singo.Chang@...iatek.com>, "wenst@...omium.org" <wenst@...omium.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	Jarried Lin (林裕哲) <Jarried.Lin@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Xavier Chang (張獻文) <Xavier.Chang@...iatek.com>
Subject: Re: [PATCH] soc: mediatek: mtk-mutex: Fix confusing usage of
 MUTEX_MOD2

Hi Angelo,

Thanks for the review.

On Mon, 2025-06-23 at 11:35 +0200, AngeloGioacchino Del Regno wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 20/06/25 04:40, Jason-JH Lin ha scritto:
> > The usage of MUTEX_MOD1 and MUTEX_MOD2 for calculating mod settings
> > over 32 has been confusing. To improve consistency and clarity,
> > these
> > defines need to fit into the same MUTEX_MOD define as possible.
> > 
> > However, MUTEX_MOD1 cannot be directly used for all SoCs because,
> > for example, the mod1 register (0x34) of MT2712 is not adjacent to
> > its mod0 register (0x2c). To address this, a `mutex_mod1_reg` field
> > is introduced in the mutex driver data structure. This allows all
> > SoCs to use a unified MUTEX_MOD to determine their register
> > offsets.
> > 
> > With this change, the separate usage of MUTEX_MOD1 and MUTEX_MOD2
> > is
> > eliminated, simplifying the logic for obtaining offsets and mod
> > IDs.
> 
> Yeah, okay, that makes sense, but...
> 
> > 
> > Fixes: e1e4f7fea375 ("soc / drm: mediatek: Move mtk mutex driver to
> > soc folder")
> 
> ...this is an improvement, it's not a fix, so please drop the Fixes
> tag.
> 

I'll drop this and send the v2.

Regards,
Jason-JH Lin

> > Signed-off-by: Jason-JH Lin <jason-jh.lin@...iatek.com>
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com>
> 
>