lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list] 
Message-Id: <20250624-bar-v4-1-9f9f9ae9f868@gmail.com>
Date: Tue, 24 Jun 2025 22:10:00 +0800
From: LiangCheng Wang <zaq14760@...il.com>
To: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>, 
 Mauro Carvalho Chehab <mchehab@...nel.org>, 
 Sakari Ailus <sakari.ailus@...ux.intel.com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-staging@...ts.linux.dev, LiangCheng Wang <zaq14760@...il.com>
Subject: [PATCH v4] staging: media: atomisp: fix coding style in
 ia_css_output.host.c

Fix multiple checkpatch.pl ERRORs and coding style issues:

- Use tabs instead of spaces for indentation
- Move trailing `if` statements to multiline format
- Remove excessive space between type and asterisk in function
  arguments
- Move assignment operator '=' to the same line for static struct
  definitions
- Remove unnecessary line breaks in function definitions

This cleanup improves code readability and follows Linux kernel
coding standards.

Signed-off-by: LiangCheng Wang <zaq14760@...il.com>
---
This patch fixes coding style violations detected by checkpatch.pl in the atomisp driver under staging.

- Use tabs instead of spaces for indentation
- Move trailing `if` statements to multiline format
- Remove excessive spaces between type and asterisk in function
  arguments
- Move assignment operator '=' to the same line for static struct
  definitions
- Remove unnecessary line breaks in function definitions

This cleanup improves code readability and follows Linux kernel coding standards.
---
Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/20250622-bar-v3-1-4cc91ef01c3a@gmail.com

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., `*to`) in function
  declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/20250621-bar-v2-1-4e6cfc779614@gmail.com

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com
---
 .../kernels/output/output_1.0/ia_css_output.host.c | 42 ++++++++++------------
 1 file changed, 19 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c47104dbffbd455bfd649b9079f88c9c..560102e81aed7a56125a97f0fff8c46de440e74d 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -22,21 +22,18 @@ static const struct ia_css_output_configuration default_output_configuration = {
 	.info = (struct ia_css_frame_info *)NULL,
 };
 
-static const struct ia_css_output0_configuration default_output0_configuration
-	= {
+static const struct ia_css_output0_configuration default_output0_configuration = {
 	.info = (struct ia_css_frame_info *)NULL,
 };
 
-static const struct ia_css_output1_configuration default_output1_configuration
-	= {
+static const struct ia_css_output1_configuration default_output1_configuration = {
 	.info = (struct ia_css_frame_info *)NULL,
 };
 
 void
-ia_css_output_encode(
-    struct sh_css_isp_output_params *to,
-    const struct ia_css_output_config *from,
-    unsigned int size)
+ia_css_output_encode(struct sh_css_isp_output_params *to,
+		     const struct ia_css_output_config *from,
+		     unsigned int size)
 {
 	(void)size;
 	to->enable_hflip = from->enable_hflip;
@@ -44,7 +41,7 @@ ia_css_output_encode(
 }
 
 int ia_css_output_config(struct sh_css_isp_output_isp_config *to,
-			 const struct ia_css_output_configuration  *from,
+			 const struct ia_css_output_configuration *from,
 			 unsigned int size)
 {
 	unsigned int elems_a = ISP_VEC_NELEMS;
@@ -66,21 +63,21 @@ int ia_css_output_config(struct sh_css_isp_output_isp_config *to,
 	return 0;
 }
 
-int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
+int ia_css_output0_config(struct sh_css_isp_output_isp_config *to,
 			  const struct ia_css_output0_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
 }
 
-int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
-		          const struct ia_css_output1_configuration *from,
+int ia_css_output1_config(struct sh_css_isp_output_isp_config *to,
+			  const struct ia_css_output1_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
 }
 
-int ia_css_output_configure(const struct ia_css_binary     *binary,
+int ia_css_output_configure(const struct ia_css_binary *binary,
 			    const struct ia_css_frame_info *info)
 {
 	if (info) {
@@ -94,8 +91,8 @@ int ia_css_output_configure(const struct ia_css_binary     *binary,
 	return 0;
 }
 
-int ia_css_output0_configure(const struct ia_css_binary    *binary,
-			    const struct ia_css_frame_info *info)
+int ia_css_output0_configure(const struct ia_css_binary *binary,
+			     const struct ia_css_frame_info *info)
 {
 	if (info) {
 		struct ia_css_output0_configuration config =
@@ -108,7 +105,7 @@ int ia_css_output0_configure(const struct ia_css_binary    *binary,
 	return 0;
 }
 
-int ia_css_output1_configure(const struct ia_css_binary     *binary,
+int ia_css_output1_configure(const struct ia_css_binary *binary,
 			     const struct ia_css_frame_info *info)
 {
 	if (info) {
@@ -123,11 +120,11 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
 }
 
 void
-ia_css_output_dump(
-    const struct sh_css_isp_output_params *output,
-    unsigned int level)
+ia_css_output_dump(const struct sh_css_isp_output_params *output,
+		   unsigned int level)
 {
-	if (!output) return;
+	if (!output)
+		return;
 	ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "enable", output->enable_hflip);
@@ -137,9 +134,8 @@ ia_css_output_dump(
 }
 
 void
-ia_css_output_debug_dtrace(
-    const struct ia_css_output_config *config,
-    unsigned int level)
+ia_css_output_debug_dtrace(const struct ia_css_output_config *config,
+			   unsigned int level)
 {
 	ia_css_debug_dtrace(level,
 			    "config.enable_hflip=%d",

---
base-commit: 3f75bfff44be0646580fe4efda45d646f9c1693b
change-id: 20250621-bar-573b8b40fb80

Best regards,
-- 
LiangCheng Wang <zaq14760@...il.com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ