linux-kernel - Re: [PATCH v4] staging: media: atomisp: fix coding style in ia_css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve_G=ziR7sJmKw4t3BRASogGQ1kWUsNNNWESFmmS4rVhw@mail.gmail.com>
Date: Tue, 24 Jun 2025 17:14:44 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: LiangCheng Wang <zaq14760@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v4] staging: media: atomisp: fix coding style in ia_css_output.host.c

On Tue, Jun 24, 2025 at 5:10 PM LiangCheng Wang <zaq14760@...il.com> wrote:
>
> Fix multiple checkpatch.pl ERRORs and coding style issues:
>
> - Use tabs instead of spaces for indentation
> - Move trailing `if` statements to multiline format
> - Remove excessive space between type and asterisk in function
>   arguments
> - Move assignment operator '=' to the same line for static struct
>   definitions
> - Remove unnecessary line breaks in function definitions
>
> This cleanup improves code readability and follows Linux kernel
> coding standards.

Thanks for a new version. Now the question is, is this the only file
in the whole (>90kLoCs!) driver that has such problems? If not, fix
them all and update Subject respectively,

-- 
With Best Regards,
Andy Shevchenko