linux-kernel - Re: [PATCH] perf build: Specify that spellcheck should use the bash dialect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xglj3gx.fsf@gmail.com>
Date: Mon, 23 Jun 2025 19:08:46 -0700
From: Collin Funk <collin.funk1@...il.com>
To: Ian Rogers <irogers@...gle.com>
Cc: James Clark <james.clark@...aro.org>,  linux-perf-users@...r.kernel.org,
  linux-kernel@...r.kernel.org,  Peter Zijlstra <peterz@...radead.org>,
  Ingo Molnar <mingo@...hat.com>,  Arnaldo Carvalho de Melo
 <acme@...nel.org>,  Namhyung Kim <namhyung@...nel.org>,  Alexander
 Shishkin <alexander.shishkin@...ux.intel.com>,  Jiri Olsa
 <jolsa@...nel.org>,  Adrian Hunter <adrian.hunter@...el.com>,  "Liang,
 Kan" <kan.liang@...ux.intel.com>
Subject: Re: [PATCH] perf build: Specify that spellcheck should use the bash
 dialect.

Hi Ian,

Ian Rogers <irogers@...gle.com> writes:

>> > $ find tools/perf -name Build | xargs grep bash
>> > tools/perf/Build:     $(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (cat $@ && rm $@ && false)
>> > tools/perf/trace/beauty/Build:        $(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (cat $@ && rm $@ && false)
>> >
>> > Collin
>>
>> In that case:
>>
>> Reviewed-by: James Clark <james.clark@...aro.org>
>>
>> And I'll send the bulk hashbang change separately.
>
> I've no objection to switching to using bash globally. It seems
> sub-optimal that we've copy-pasted the shellcheck command across many
> different Build files and that this patch will cause the
> tools/perf/tests/Build one to differ. My preference would be to have a
> global definition probably in Makefile.perf, then use it consistently.
> Alternative all shellcheck invocations can pass "-s bash" for the sake
> of consistency.  Fwiw, I think the 'tools/arch/x86/tools/gen-insn-*'
> which is to some extent taken from the kernel's 'arch/x86/tools' is
> okay with the change too.

Good point. It turns out there was a SHELLCHECK variable in
Makefile.perf, but it was not used consistently.

I have submitted V2 that adds the '-s bash' option to the definition and
actually uses the variable [1]

Collin

[1] https://lore.kernel.org/all/f7ea3a430dc2bd77656c50f93283547d1245e2fe.1750730589.git.collin.funk1@gmail.com/