| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fW6oMGcGcBgxVWOrkxcPRo1EDVAHe4m0F-ratRkpKjL0w@mail.gmail.com> Date: Mon, 23 Jun 2025 22:21:53 -0700 From: Ian Rogers <irogers@...gle.com> To: Collin Funk <collin.funk1@...il.com> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, "Liang, Kan" <kan.liang@...ux.intel.com>, James Clark <james.clark@...aro.org>, Charlie Jenkins <charlie@...osinc.com>, Ravi Bangoria <ravi.bangoria@....com>, "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] [PATCH] perf build: Specify that shellcheck should use the bash dialect. On Mon, Jun 23, 2025 at 7:06 PM Collin Funk <collin.funk1@...il.com> wrote: > > When someone has a global shellcheckrc file, for example at > ~/.config/shellcheckrc, with the directive 'shell=sh', building perf > will fail with many shellcheck errors like: > > In tests/shell/base_probe/test_adding_kernel.sh line 294: > (( TEST_RESULT += $? )) > ^---------------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined. > > For more information: > https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is... > make[5]: *** [tests/Build:91: tests/shell/base_probe/test_adding_kernel.sh.shellcheck_log] Error 1 > > Passing the '-s bash' option ensures that it runs correctly regardless > of a developers global configuration. > > This patch adds '-s bash' to the SHELLCHECK variable in Makefile.perf > and makes use of the variable consistently. > > Signed-off-by: Collin Funk <collin.funk1@...il.com> > --- > tools/perf/Build | 2 +- > tools/perf/Makefile.perf | 2 +- > tools/perf/arch/x86/Build | 2 +- > tools/perf/arch/x86/tests/Build | 2 +- > tools/perf/tests/Build | 2 +- > tools/perf/trace/beauty/Build | 2 +- > tools/perf/util/Build | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/Build b/tools/perf/Build > index 06107f1e1d42..e69665bf9dce 100644 > --- a/tools/perf/Build > +++ b/tools/perf/Build > @@ -73,7 +73,7 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-y += $(SHELL_TEST_LOGS) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index d4c7031b01a7..6810d321ff73 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -252,7 +252,7 @@ endif > ifeq ($(NO_SHELLCHECK),1) > SHELLCHECK := > else > - SHELLCHECK := $(shell which shellcheck 2> /dev/null) > + SHELLCHECK := $(shell which shellcheck 2> /dev/null) -s bash Could we also place the "-a -S warning" warning here too? Thanks, Ian > endif > > # shellcheck is using in tools/perf/tests/Build with option -a/--check-sourced ( > diff --git a/tools/perf/arch/x86/Build b/tools/perf/arch/x86/Build > index afae7b8f6bd6..71e2553e5af1 100644 > --- a/tools/perf/arch/x86/Build > +++ b/tools/perf/arch/x86/Build > @@ -10,6 +10,6 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-test-y += $(SHELL_TEST_LOGS) > diff --git a/tools/perf/arch/x86/tests/Build b/tools/perf/arch/x86/tests/Build > index 5e00cbfd2d56..fd3af16f63bb 100644 > --- a/tools/perf/arch/x86/tests/Build > +++ b/tools/perf/arch/x86/tests/Build > @@ -22,6 +22,6 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-test-y += $(SHELL_TEST_LOGS) > diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build > index 2181f5a92148..4a27fde30eb6 100644 > --- a/tools/perf/tests/Build > +++ b/tools/perf/tests/Build > @@ -89,7 +89,7 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-test-y += $(SHELL_TEST_LOGS) > > diff --git a/tools/perf/trace/beauty/Build b/tools/perf/trace/beauty/Build > index f50ebdc445b8..727ce0a5c30a 100644 > --- a/tools/perf/trace/beauty/Build > +++ b/tools/perf/trace/beauty/Build > @@ -31,6 +31,6 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-y += $(SHELL_TEST_LOGS) > diff --git a/tools/perf/util/Build b/tools/perf/util/Build > index 7910d908c814..626a359fee1e 100644 > --- a/tools/perf/util/Build > +++ b/tools/perf/util/Build > @@ -421,7 +421,7 @@ endif > > $(OUTPUT)%.shellcheck_log: % > $(call rule_mkdir) > - $(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > + $(Q)$(call echo-cmd,test)$(SHELLCHECK) -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) > > perf-util-y += $(SHELL_TEST_LOGS) > > -- > 2.49.0 >
Powered by blists - more mailing lists