linux-kernel - Re: [PATCH] mei: vsc: Remove unused irq functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025062412-immobile-unclothed-0fc5@gregkh>
Date: Tue, 24 Jun 2025 16:31:30 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: Hans de Goede <hdegoede@...hat.com>, alexander.usyskin@...el.com,
	arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: vsc: Remove unused irq functions

On Tue, Jun 24, 2025 at 11:17:24AM +0000, Dr. David Alan Gilbert wrote:
> * Hans de Goede (hdegoede@...hat.com) wrote:
> > Hi David,
> > 
> > On 17-Jun-25 2:34 AM, linux@...blig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > 
> > > vsc_tp_request_irq() and vsc_tp_free_irq() last uses were removed in 2024
> > > by
> > > commit 9b5e045029d8 ("mei: vsc: Don't stop/restart mei device during system
> > > suspend/resume")
> > > 
> > > Remove them.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > 
> > Alexander pointed me at this patch because I just posted
> > almost the same patch:
> > 
> > https://lore.kernel.org/lkml/20250623085052.12347-2-hansg@kernel.org/
> > 
> > Normally I would say lets go with your (David's) version since
> > you posted your patch first.
> > 
> > But your patch is missing the removal of the function prototypes
> > from vsc-tp.h, so in this case I think we should go with my version.
> 
> Oops, yep that makes sense to me.

Ok, I'll go take your series now, sorry for the delay.

greg k-h