linux-kernel - Re: [PATCH] net: thunderbolt: Enable e2e flow control in two direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250624153805.GC2824380@black.fi.intel.com>
Date: Tue, 24 Jun 2025 18:38:05 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: zhangjianrong <zhangjianrong5@...wei.com>
Cc: michael.jamet@...el.com, YehezkelShB@...il.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, guhengsheng@...ilicon.com,
	caiyadong@...wei.com, xuetao09@...wei.com, lixinghang1@...wei.com
Subject: Re: [PATCH] net: thunderbolt: Enable e2e flow control in two
 direction

Hi,

Perhaps $subject:

net: thunderbolt: Enable end-to-end flow control also in transmit

or so.

On Tue, Jun 24, 2025 at 05:32:05PM +0800, zhangjianrong wrote:
> According to USB4 specification, if E2E flow control is disabled for
> the Transmit Descriptor Ring, the Host Interface Adapter Layer shall
> not require any credits to be available before transmitting a Tunneled
> Packet from this Transmit Descriptor Ring, so e2e flow control should
> be enabled in two direction.

be enabled in both directions.

> Signed-off-by: zhangjianrong <zhangjianrong5@...wei.com>

Good finding, though.

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

> ---
>  drivers/net/thunderbolt/main.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c
> index 0a53ec293d04..643cf67840b5 100644
> --- a/drivers/net/thunderbolt/main.c
> +++ b/drivers/net/thunderbolt/main.c
> @@ -924,8 +924,12 @@ static int tbnet_open(struct net_device *dev)
>  
>  	netif_carrier_off(dev);
>  
> -	ring = tb_ring_alloc_tx(xd->tb->nhi, -1, TBNET_RING_SIZE,
> -				RING_FLAG_FRAME);
> +	flags = RING_FLAG_FRAME;
> +	/* Only enable full E2E if the other end supports it too */
> +	if (tbnet_e2e && net->svc->prtcstns & TBNET_E2E)
> +		flags |= RING_FLAG_E2E;
> +
> +	ring = tb_ring_alloc_tx(xd->tb->nhi, -1, TBNET_RING_SIZE, flags);
>  	if (!ring) {
>  		netdev_err(dev, "failed to allocate Tx ring\n");
>  		return -ENOMEM;
> @@ -944,11 +948,6 @@ static int tbnet_open(struct net_device *dev)
>  	sof_mask = BIT(TBIP_PDF_FRAME_START);
>  	eof_mask = BIT(TBIP_PDF_FRAME_END);
>  
> -	flags = RING_FLAG_FRAME;
> -	/* Only enable full E2E if the other end supports it too */
> -	if (tbnet_e2e && net->svc->prtcstns & TBNET_E2E)
> -		flags |= RING_FLAG_E2E;
> -
>  	ring = tb_ring_alloc_rx(xd->tb->nhi, -1, TBNET_RING_SIZE, flags,
>  				net->tx_ring.ring->hop, sof_mask,
>  				eof_mask, tbnet_start_poll, net);
> -- 
> 2.34.1