linux-kernel - Re: [PATCH v8 4/9] rust: acpi: add `acpi::DeviceId` abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ggAFg-pcujf5BysNNp3ncStOWruyAemFLJB5=95uu9XA@mail.gmail.com>
Date: Tue, 24 Jun 2025 19:56:32 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Igor Korotin <igor.korotin.linux@...il.com>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Rob Herring <robh@...nel.org>, 
	Saravana Kannan <saravanak@...gle.com>, Alex Hung <alex.hung@....com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Jakub Kicinski <kuba@...nel.org>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Remo Senekowitsch <remo@...nzli.dev>, 
	Tamir Duberstein <tamird@...il.com>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Xiangfei Ding <dingxiangfei2009@...il.com>, 
	devicetree@...r.kernel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Benno Lossin <lossin@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Len Brown <lenb@...nel.org>, Trevor Gross <tmgross@...ch.edu>
Subject: Re: [PATCH v8 4/9] rust: acpi: add `acpi::DeviceId` abstraction

On Sat, Jun 21, 2025 at 12:06 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> On Fri, Jun 20, 2025 at 04:24:25PM +0100, Igor Korotin wrote:
> > `acpi::DeviceId` is an abstraction around `struct acpi_device_id`.
> >
> > This is used by subsequent patches, in particular the i2c driver
> > abstractions, to create ACPI device ID tables.
>
> I think this should say something like
>
>         "Enable drivers to build ACPI device ID tables, to be consumed by the
>          corresponding bus abstractions, such as platform or I2C."
>
> instead.
>
> If we agree, I can change it when applying the patch -- no need to resend.
>
> >
> > Signed-off-by: Igor Korotin <igor.korotin.linux@...il.com>
>
> @Rafael: Can I get an ACK for this one, such that I can take it together with
> all other patches through the driver-core tree?

I don't see anything objectionable in it, even though Rust code is
still kind of outside my confidence zone ATM.

Anyway, please feel free to add

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

to this.

Thanks!