linux-kernel - Re: [PATCH v8 1/9] rust: device: implement FwNode::is_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFsOrAqpBtz9OAEI@cassiopeiae>
Date: Tue, 24 Jun 2025 22:46:36 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
	Igor Korotin <igor.korotin.linux@...il.com>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Miguel Ojeda <ojeda@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Alex Hung <alex.hung@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jakub Kicinski <kuba@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Remo Senekowitsch <remo@...nzli.dev>,
	Tamir Duberstein <tamird@...il.com>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Wedson Almeida Filho <wedsonaf@...il.com>,
	Xiangfei Ding <dingxiangfei2009@...il.com>,
	devicetree@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Benno Lossin <lossin@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>, Len Brown <lenb@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>
Subject: Re: [PATCH v8 1/9] rust: device: implement FwNode::is_of_node()

On Sat, Jun 21, 2025 at 12:40:02AM +0200, Danilo Krummrich wrote:
> On Fri, Jun 20, 2025 at 04:15:04PM +0100, Igor Korotin wrote:
> > From: Danilo Krummrich <dakr@...nel.org>
> > 
> > Implement FwNode::is_of_node() in order to check whether a FwNode
> > instance is embedded in a struct device_node.
> > 
> > Signed-off-by: Danilo Krummrich <dakr@...nel.org>
> > Signed-off-by: Igor Korotin <igor.korotin.linux@...il.com>
> > ---
> >  MAINTAINERS                    | 1 +
> >  rust/helpers/helpers.c         | 1 +
> >  rust/helpers/of.c              | 8 ++++++++
> >  rust/kernel/device/property.rs | 7 +++++++
> >  4 files changed, 17 insertions(+)
> >  create mode 100644 rust/helpers/of.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9f724cd556f4..1e918319cff4 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18579,6 +18579,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> >  F:	Documentation/ABI/testing/sysfs-firmware-ofw
> >  F:	drivers/of/
> >  F:	include/linux/of*.h
> > +F:	rust/helpers/of.c
> 
> @Rob: Any concerns about adding the OF Rust helpers to the OF entry?

Given that you proposed to use is_of_node() and rust/kernel/of.rs is under your
MAINTAINERS entry as well, I assume this is fine.

If not, please let me know.